Skip to content

ci: show the gate as CI Status and mirror it as ci-status - #149

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/ci-status-alias
Nov 12, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/ci-status-alias

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: owner decision D3 (rename the required gate to CI Status), step A for this repository.

Summary

The ci-status job now displays as CI Status. A new report-ci-status job, named ci-status, reports its conclusion under the old name. Until the ci-gate org ruleset requires CI Status, both contexts are on every head.

Fix

Verification

  • actionlint is clean.
  • This PR's own checks report both CI Status and ci-status.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe

The ci-status job displays as `CI Status`, and a new report-ci-status
job reports its conclusion under the old name `ci-status`, the context
the ci-gate org ruleset requires today. aggregate-results moves to the
ci-workflows commit with the alias-jobs input and names the mirror, so
contract-only runs still read as contract-only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VQb9Q2ceZLXhTR4d1vkTCe
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T06:17:25.348092Z 54f28a9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kyle-sexton
kyle-sexton enabled auto-merge (squash) November 12, 2026 06:16
@github-actions

Copy link
Copy Markdown

claude-review reviewed 54f28a9257e71c47d5d0747e7f8e8a9b44b2ae37: 0 finding(s), 0 as inline comments.

No findings. The PR changes one file, .github/workflows/pr-require-checks.yml.

  • Mirror job: report-ci-status (displayed as ci-status) depends on the renamed job CI Status through its unchanged job id, ci-status. It runs under if: always(), so it also goes red when the gate is skipped or cancelled. That is the right behavior for a required-check mirror.
  • Permissions: permissions: {} is enough, because the job only reads needs.*.result and runs a shell test.
  • Aggregate action: alias-jobs: ci-status is passed to the new pin of aggregate-results, as the PR describes. The new SHA's behavior (alias-jobs support, defaults matching the old pin) is author-claimed and unverified. I could not fetch ci-workflows from this sandbox.
  • Other references to ci-status: AGENTS.md, REVIEW.md, dependabot.yml and the other workflows' comments name the context ci-status. That stays accurate because the mirror keeps the old context name until the ruleset moves to CI Status.
  • Closing issue: none. The PR uses the "No related issue" escape with a stated reason, so there are no acceptance criteria to check.
  • Verification: "actionlint is clean" and "both contexts appear on this PR" are author-claimed. I did not run either.
  • Manifests: no manifests changed, so no manifest <field> lines apply.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 54f28a9257e71c47d5d0747e7f8e8a9b44b2ae37: 0 finding(s), 0 as inline comments.

Security review: PR #149 (head 54f28a9)

Findings: 0. critical-findings: 0

The diff is one file, .github/workflows/pr-require-checks.yml. I read it as a change to a merge-gate control, the ci-status hold steps.

  • Mirror job report-ci-status.
    • It runs with permissions: {}.
    • It runs under if: always() and reads only needs.ci-status.result.
    • It passes that value through env: RESULT, not by interpolating it into run:, so there is no expression injection.
    • It exits 0 only when $RESULT is exactly success. A skipped, cancelled or failed CI Status makes the mirror fail, so it fails closed.
    • Nothing here widens the gate. It adds a second status that is never greener than the first.
  • Rename to CI Status. This only changes the display name. The needs list and the if: ${{ !cancelled() }} condition are unchanged. The alias-jobs: ci-status input tells the aggregator to ignore the mirror in its run-shape reads. That reads as a guard against the mirror being counted as a lane, not as a way to skip a lane. The aggregator's behaviour is outside this diff, so I could not confirm it.
  • Pin bump. aggregate-results moves from the v0.39.8 tag to the full 40-character SHA ac4d8780de793b20e60a66890e767df579c80d83, which is dated 2026-11-11 and has no release tag. It stays pinned to a full SHA in the org's own ci-workflows repo, and the job token and permissions are unchanged. Actions pinning is zizmor's lane. Repin ceremony is one of the owner's named friction holds, so I treat it as a note and not a finding. I could not read the new commit's contents or diff it against the old pin, because the sandbox refused the gh api calls to melodic-software/ci-workflows. So I have not verified that the new action version has no logic change that weakens the aggregation. Please have a person confirm that the SHA is on ci-workflows main and that its changes since 594987a only add alias-jobs and report-ci-status support.

No manifests, scripts, secrets or instruction surfaces changed. No manifest <field> lines apply.

@kyle-sexton
kyle-sexton merged commit a2e34ce into main Nov 12, 2026
13 checks passed
@kyle-sexton
kyle-sexton deleted the ci/ci-status-alias branch November 12, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant