Repository navigation
fix: keep the local gitleaks scan in the cross-cutting record - #156
Conversation
The cross-cutting record set no gitleaks command because no CI job here runs one, which switched off the secret scan the bundled toolchain default ran for this repository. Add the scan back as a stated deviation from CI, with the command, version and checksum of the gitleaks composite at ci-workflows v0.39.8, and correct one line cite that moved when the job display names changed. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed No findings. The PR touches only
Verifier dropped 0 of 0 candidates. |
|
claude-security-review reviewed Security review: PR #156 (head 05e8081)No security findings. The only change is
critical-findings: 0 |
…the cross-cutting record (#166) Refs: melodic-software/claude-code-plugins#15723 ## Summary Since #154 and #156, #164 moved the check-managed-files pin to ci-workflows v0.74.0 (`944d346`), and #163 added a header line to `pr-automerge-dependabot.yml`. The cross-cutting record's notes still named v0.71.0 and line ranges one line short. This change corrects those three citations and nothing else. ## Fix - `check-managed-files@8e1076f v0.71.0` becomes `@944d346 v0.74.0`, matching `pr-check-managed-files-hosted.yml:118`. - `pr-automerge-dependabot.yml:21-29` becomes `:22-30` (the job), and `:3-7` becomes `:3-8` (the header sentence). No command, version or checksum changes. #162 also moved the lychee-offline and typos composites to v0.74.0. I diffed them against v0.39.8 (`594987a`): their version, sha256 and argument defaults are unchanged. lychee-offline moved its run step into `run.sh` unchanged, and it now falls back to a bundled `lychee.toml` only when the caller has none; this repository has one. The other records' citations still hold: apart from that header line, every CI edit since #156 changed lines in place. ## Verification - Schema: `check-jsonschema --schemafile docs/contracts/ecosystem-commands/ecosystem.schema.json` (claude-code-plugins `origin/main`) over all six records printed `ok -- validation done`. - Method: a throwaway `git clone --shared` of this branch, with `refs/remotes/origin/main` at #156's merge `c12a04f`. The range runs #157 through this commit: 16 files, covering workflows, dependabot, AGENTS.md, REVIEW.md, docs and five SKILL.md. Every tool runs with `env -C <clone>`. Toolchain skill text is 1.4.0. - Run 1, `/toolchain:check all`, 11:37 PM to 11:38 PM EST 2026-11-15. Overall line: `Overall: PASS (3 of 3 ecosystems passed)`. | Ecosystem | Build | Test | Lint | Status | |---|---|---|---|---| | bash | — | pass | pass | PASS | | powershell | — | — | pass | PASS | | markdown | — | — | pass | PASS | | typescript | — | — | — | — | - bash: the sync-local suite has 73 passed, 0 failed and 0 skipped (pwsh present), and the docs-naming suite has 9 ok. shellcheck and `bash -n` over CI's list exited 0. - powershell: PSScriptAnalyzer reported 0 findings. - typescript: every command is null. - No dotnet, python or go project files exist. - The output contains no `skip (unresolved`. - Run 2, `/toolchain:lint`, 11:38 PM to 11:39 PM EST. Overall line: `Overall: PASS (2 of 2 ecosystems passed)`. - markdown passed, and yaml is all null. - cross-cutting passed: check-docs-naming, jq, the relative-link check, lychee (0 errors), typos, and `gitleaks dir . --config .gitleaks.toml --no-banner --redact` (no leaks). - Installed typos is 1.52.2; the pin is 1.50.3. - The verify gate passed on this commit: schema validation plus the cross-cutting check-cmd. ## Remaining melodic-software/claude-code-plugins#15723 stays open after this pull request. Its baseline steps are still owed: a `/toolchain:check all` and a `/toolchain:lint` with the bundled defaults (records removed) on one range, then the comparison of their command lists with the record runs above. This pass had a two-run budget, which went to the record runs. ## Related - #154 and #156, which merged the records this change corrects - melodic-software/claude-code-plugins#15723, melodic-software/claude-code-plugins#15703 (parent) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Refs: melodic-software/claude-code-plugins#15723
Summary
Puts the local gitleaks secret scan back into
.claude/ecosystems/cross-cutting.yaml. The record merged in #154 set no gitleaks command because no CI job here runs one, and that switched off the scan the bundled toolchain default ran for this repository. The owner had not approved removing a secret scan.Fix
check-cmdgainsgitleaks dir . --config .gitleaks.toml --no-banner --redactas its last check; it contributes to the status like every other line. No existing check changes.opt-in,install-hintandtool-pinname gitleaks.pr-automerge-dependabot.ymlmoved by a line when the job display names changed; it is corrected.Verification
gitleaks dir8.30.1 over this branch's tree: no leaks found.gitleaks diralso reads untracked and git-ignored files, as the notes say.Remaining
Issue melodic-software/claude-code-plugins#15723 stays open after this pull request; its baseline steps and recorded
/toolchain:check alloutput are still owed.Whether a record should keep other bundled checks that CI does not run is an open owner question; this pull request changes only the secret scan.
Related
session: GitHub Support
🤖 Generated with Claude Code