Skip to content

fix: keep the local gitleaks scan in the cross-cutting record - #156

Merged
kyle-sexton merged 1 commit into
mainfrom
fix/ecosystem-records-restore-gitleaks
Nov 14, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
fix/ecosystem-records-restore-gitleaks

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/claude-code-plugins#15723

Summary

Puts the local gitleaks secret scan back into .claude/ecosystems/cross-cutting.yaml. The record merged in #154 set no gitleaks command because no CI job here runs one, and that switched off the scan the bundled toolchain default ran for this repository. The owner had not approved removing a secret scan.

Fix

  • check-cmd gains gitleaks dir . --config .gitleaks.toml --no-banner --redact as its last check; it contributes to the status like every other line. No existing check changes.
  • The notes state the line as a deviation from CI: no CI job here runs gitleaks. The command, version (8.30.1) and checksum are those of the gitleaks composite at melodic-software/ci-workflows v0.39.8, which this repository does not call.
  • opt-in, install-hint and tool-pin name gitleaks.
  • One cite into pr-automerge-dependabot.yml moved by a line when the job display names changed; it is corrected.

Verification

  • The record validates against the ecosystem-commands schema.
  • gitleaks dir 8.30.1 over this branch's tree: no leaks found.
  • An independent review read every cite the change adds or moves, compared the record key by key with the version on main, and ran the command shape with stub tools: exit 0 when clean, exit 1 when gitleaks finds something, errors or is missing. READY, no blocking finding.
  • A probe on the build host showed gitleaks dir also reads untracked and git-ignored files, as the notes say.

Remaining

Issue melodic-software/claude-code-plugins#15723 stays open after this pull request; its baseline steps and recorded /toolchain:check all output are still owed.

Whether a record should keep other bundled checks that CI does not run is an open owner question; this pull request changes only the secret scan.

Related

session: GitHub Support

🤖 Generated with Claude Code

The cross-cutting record set no gitleaks command because no CI job here
runs one, which switched off the secret scan the bundled toolchain
default ran for this repository. Add the scan back as a stated deviation
from CI, with the command, version and checksum of the gitleaks composite
at ci-workflows v0.39.8, and correct one line cite that moved when the
job display names changed.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T15:32:54.322249Z 05e8081 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 05e8081e57ac0b61f18f194048411bc6092ebfce: 0 finding(s), 0 as inline comments.

No findings. The PR touches only .claude/ecosystems/cross-cutting.yaml.

  • Command shape: gitleaks dir . --config .gitleaks.toml --no-banner --redact || rc=1 sits before the final test "$rc" -eq 0, so it feeds the aggregate status like the other checks. .gitleaks.toml exists at the repo root, which matches the opt-in text.
  • Consistency: tool-pin, install-hint and opt-in all name gitleaks 8.30.1. The header comment's "final line, gitleaks" matches the command order.
  • Cite change: I read .github/workflows/pr-automerge-dependabot.yml at the head commit. Lines 21-29 span the jobs: key through runner: ubuntu-24.04, so the corrected cite (:21-28 to :21-29) fits.
  • Not verified: I did not run gitleaks, the schema validation or the stub-tool exit-code checks. The PR body's verification statements are author-claimed.
  • Closing issue: the PR says it only refs the parent issue, and no acceptance criteria were present to check.
  • Embedded instructions: none in the PR context.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 05e8081e57ac0b61f18f194048411bc6092ebfce: 0 finding(s), 0 as inline comments.

Security review: PR #156 (head 05e8081)

No security findings. The only change is .claude/ecosystems/cross-cutting.yaml. It adds a local gitleaks dir . --config .gitleaks.toml --no-banner --redact secret scan to check-cmd, a gitleaks: "8.30.1" pin, an install-hint line with a SHA-256 for the Linux archive, an opt-in string update, and header and notes text.

  • Skip gate: A change to a check runner can't take the "no security surface" skip, so I read it in full.
  • Instruction-surface lens: The diff adds a control and deletes, narrows or softens none, so no protected class is touched. I did not consult the instruction exception register.
  • Trust controls and trusted paths: None are touched. The diff has no trusted-actor list, token-scope or kill-switch change, merge hold, .github/actions/ change, CODEOWNERS or .gitmodules.
  • Manifests: No plugin.json or marketplace.json is in the diff, so there are no manifest <field> lines.
  • New command:
    • It is a local, developer-run command like the neighbouring lychee and typos lines. It adds no CI job, workflow, token, secret exposure or other path for untrusted input.
    • --redact keeps any detected secret out of the terminal and logs.
    • It reads .gitleaks.toml from the working tree. That file is not in this diff, and it is a standards-synced file validated upstream.
  • Settled threads, prior findings and PR context: No such files were supplied.

critical-findings: 0

@kyle-sexton
kyle-sexton merged commit c12a04f into main Nov 14, 2026
12 checks passed
@kyle-sexton
kyle-sexton deleted the fix/ecosystem-records-restore-gitleaks branch November 14, 2026 15:34
kyle-sexton added a commit that referenced this pull request Nov 16, 2026
…the cross-cutting record (#166)

Refs: melodic-software/claude-code-plugins#15723

## Summary

Since #154 and #156, #164 moved the check-managed-files pin to
ci-workflows v0.74.0 (`944d346`), and #163 added a header line to
`pr-automerge-dependabot.yml`. The cross-cutting record's notes still
named v0.71.0 and line ranges one line short. This change corrects those
three citations and nothing else.

## Fix

- `check-managed-files@8e1076f v0.71.0` becomes `@944d346 v0.74.0`,
matching `pr-check-managed-files-hosted.yml:118`.
- `pr-automerge-dependabot.yml:21-29` becomes `:22-30` (the job), and
`:3-7` becomes `:3-8` (the header sentence).

No command, version or checksum changes. #162 also moved the
lychee-offline and typos composites to v0.74.0. I diffed them against
v0.39.8 (`594987a`): their version, sha256 and argument defaults are
unchanged. lychee-offline moved its run step into `run.sh` unchanged,
and it now falls back to a bundled `lychee.toml` only when the caller
has none; this repository has one. The other records' citations still
hold: apart from that header line, every CI edit since #156 changed
lines in place.

## Verification

- Schema: `check-jsonschema --schemafile
docs/contracts/ecosystem-commands/ecosystem.schema.json`
(claude-code-plugins `origin/main`) over all six records printed `ok --
validation done`.
- Method: a throwaway `git clone --shared` of this branch, with
`refs/remotes/origin/main` at #156's merge `c12a04f`. The range runs
#157 through this commit: 16 files, covering workflows, dependabot,
AGENTS.md, REVIEW.md, docs and five SKILL.md. Every tool runs with `env
-C <clone>`. Toolchain skill text is 1.4.0.
- Run 1, `/toolchain:check all`, 11:37 PM to 11:38 PM EST 2026-11-15.
Overall line: `Overall: PASS (3 of 3 ecosystems passed)`.

| Ecosystem | Build | Test | Lint | Status |
|---|---|---|---|---|
| bash | — | pass | pass | PASS |
| powershell | — | — | pass | PASS |
| markdown | — | — | pass | PASS |
| typescript | — | — | — | — |

- bash: the sync-local suite has 73 passed, 0 failed and 0 skipped (pwsh
present), and the docs-naming suite has 9 ok. shellcheck and `bash -n`
over CI's list exited 0.
  - powershell: PSScriptAnalyzer reported 0 findings.
  - typescript: every command is null.
  - No dotnet, python or go project files exist.
  - The output contains no `skip (unresolved`.
- Run 2, `/toolchain:lint`, 11:38 PM to 11:39 PM EST. Overall line:
`Overall: PASS (2 of 2 ecosystems passed)`.
  - markdown passed, and yaml is all null.
- cross-cutting passed: check-docs-naming, jq, the relative-link check,
lychee (0 errors), typos, and `gitleaks dir . --config .gitleaks.toml
--no-banner --redact` (no leaks).
  - Installed typos is 1.52.2; the pin is 1.50.3.
- The verify gate passed on this commit: schema validation plus the
cross-cutting check-cmd.

## Remaining

melodic-software/claude-code-plugins#15723 stays open after this pull
request. Its baseline steps are still owed: a `/toolchain:check all` and
a `/toolchain:lint` with the bundled defaults (records removed) on one
range, then the comparison of their command lists with the record runs
above. This pass had a two-run budget, which went to the record runs.

## Related

- #154 and #156, which merged the records this change corrects
- melodic-software/claude-code-plugins#15723,
melodic-software/claude-code-plugins#15703 (parent)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant