Repository navigation
docs: align agent instructions with CI and drop incident history - #157
Conversation
AGENTS.md named a shell-lint file list narrower than CI's, a bash -n fallback that parsed only its first file, and a push trigger wider than the workflow's. Three plugin-ops skills and the test notes stated rules as past incidents. The design boundary now records the sync-local fallback as an exception. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmdRVNmhT8VQkrZ53Fw
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security findings on PR #157 at 72fbf0e. All 8 changed files are Markdown or YAML prose. The diff has no scripts, workflows, plugin or marketplace manifests,
Under the throughput-phase section, no named friction hold is weakened. critical-findings: 0 |
|
claude-review reviewed No findings. The PR only changes docs and skill text, and I checked each factual claim it makes against the repository at head.
The PR names no closing issue, only the no-issue escape with a reason. There were no settled-threads or prior-findings files, and no manifests changed. The Verifier dropped 0 of 0 candidates. |
No related issue: a one-line comment correction left over from the prompt audit merged in #157. ## Summary The header comment of `.github/workflows/pr-require-checks.yml` said the checks run on every push. The trigger is `pull_request` and `push: branches: [main]`. ## Fix The comment now reads "every pull request and every push to `main`", matching `AGENTS.md`. No workflow behavior changes. ## Verification Comment-only change; the workflow's own run on this pull request parses the file. ## Related - #157 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_015XWwmdRVNmhT8VQkrZ53Fw Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…the cross-cutting record (#166) Refs: melodic-software/claude-code-plugins#15723 ## Summary Since #154 and #156, #164 moved the check-managed-files pin to ci-workflows v0.74.0 (`944d346`), and #163 added a header line to `pr-automerge-dependabot.yml`. The cross-cutting record's notes still named v0.71.0 and line ranges one line short. This change corrects those three citations and nothing else. ## Fix - `check-managed-files@8e1076f v0.71.0` becomes `@944d346 v0.74.0`, matching `pr-check-managed-files-hosted.yml:118`. - `pr-automerge-dependabot.yml:21-29` becomes `:22-30` (the job), and `:3-7` becomes `:3-8` (the header sentence). No command, version or checksum changes. #162 also moved the lychee-offline and typos composites to v0.74.0. I diffed them against v0.39.8 (`594987a`): their version, sha256 and argument defaults are unchanged. lychee-offline moved its run step into `run.sh` unchanged, and it now falls back to a bundled `lychee.toml` only when the caller has none; this repository has one. The other records' citations still hold: apart from that header line, every CI edit since #156 changed lines in place. ## Verification - Schema: `check-jsonschema --schemafile docs/contracts/ecosystem-commands/ecosystem.schema.json` (claude-code-plugins `origin/main`) over all six records printed `ok -- validation done`. - Method: a throwaway `git clone --shared` of this branch, with `refs/remotes/origin/main` at #156's merge `c12a04f`. The range runs #157 through this commit: 16 files, covering workflows, dependabot, AGENTS.md, REVIEW.md, docs and five SKILL.md. Every tool runs with `env -C <clone>`. Toolchain skill text is 1.4.0. - Run 1, `/toolchain:check all`, 11:37 PM to 11:38 PM EST 2026-11-15. Overall line: `Overall: PASS (3 of 3 ecosystems passed)`. | Ecosystem | Build | Test | Lint | Status | |---|---|---|---|---| | bash | — | pass | pass | PASS | | powershell | — | — | pass | PASS | | markdown | — | — | pass | PASS | | typescript | — | — | — | — | - bash: the sync-local suite has 73 passed, 0 failed and 0 skipped (pwsh present), and the docs-naming suite has 9 ok. shellcheck and `bash -n` over CI's list exited 0. - powershell: PSScriptAnalyzer reported 0 findings. - typescript: every command is null. - No dotnet, python or go project files exist. - The output contains no `skip (unresolved`. - Run 2, `/toolchain:lint`, 11:38 PM to 11:39 PM EST. Overall line: `Overall: PASS (2 of 2 ecosystems passed)`. - markdown passed, and yaml is all null. - cross-cutting passed: check-docs-naming, jq, the relative-link check, lychee (0 errors), typos, and `gitleaks dir . --config .gitleaks.toml --no-banner --redact` (no leaks). - Installed typos is 1.52.2; the pin is 1.50.3. - The verify gate passed on this commit: schema validation plus the cross-cutting check-cmd. ## Remaining melodic-software/claude-code-plugins#15723 stays open after this pull request. Its baseline steps are still owed: a `/toolchain:check all` and a `/toolchain:lint` with the bundled defaults (records removed) on one range, then the comparison of their command lists with the record runs above. This pass had a two-run budget, which went to the record runs. ## Related - #154 and #156, which merged the records this change corrects - melodic-software/claude-code-plugins#15723, melodic-software/claude-code-plugins#15703 (parent) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: findings from a prompt audit of this repository's instruction files, fixed in place.
Summary
Agent instruction files stated facts the repository contradicts and stated rules as past incidents.
Fix
AGENTS.md: the shell-lint command is CI's (shellcheck scripts/*.sh .cursor/install.sh); thebash -nfallback loops per file, becausebash -n a bparses onlya; the workflow trigger reads "every pull request and every push tomain"; the lint heading drops "there is no configured linter" and its anchor follows; the second suite,scripts/test-check-docs-naming.sh, is named; the pinned-cases list states current behavior.plugin-opsskills:sync-local,install-marketplaceandupdate-pluginsstate the rule and its reason in place of the incident that produced it.install-marketplace,update-pluginsandverify-plugindescriptions say when to use the skill.design-automation: the generated prompt covers the listed parts without a fixed order, with numbered steps only where order matters.docs/plugin-philosophy.md: the design boundary records thesync-localfallback (org env var, known checkout paths, repository URL) as an exception..claude/ecosystems/bash.yaml: line citations ofAGENTS.mdfollow the edit, and the note on the narrowerAGENTS.mdfile list is removed.The 2026-08-30 dates in the two skills are unchanged; no Cursor page was fetched.
Verification
Run locally on the branch: skill frontmatter check,
bash scripts/check-docs-naming.sh --check,typosover the changed paths, and an offlinelycheerun with fragments overAGENTS.mdanddocs/plugin-philosophy.md. All passed.Related
None.
🤖 Generated with Claude Code
https://claude.ai/code/session_015XWwmdRVNmhT8VQkrZ53Fw