Skip to content

ci: run every shared git hook through the aggregate lefthook remote - #177

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/lefthook-aggregate-remote
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/lefthook-aggregate-remote

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: org-wide rollout of the shared git hooks (every repository gets the same hook set from one source).

Summary

Switches this repository's lefthook remote from the guardrails-only config to claude-code-plugins' root lefthook-remote.yml, which extends all 11 hook plugins' remote configs: guardrails, code-tidying, actionlint, bash-format, go-format, instruction-placement, javascript-format, markdown-format, powershell-format, python-format and spelling. Lists the formatter cleanup commit that landed first in .git-blame-ignore-revs.

Fix

  • lefthook.yml: configs: names lefthook-remote.yml; ref: main and refetch_frequency: 24h are unchanged.
  • .git-blame-ignore-revs: the squash commit of this repository's formatter-only cleanup PR.
  • Where lefthook.yml extends the standards .lefthook/base.yml: per-command skip: true on its typos and markdownlint lanes, the opt-out that fragment's header documents, because the remote's spelling and markdown-format jobs run the same tools on the same configs. gitleaks keeps running: its default ruleset is far broader than the guardrails secret scan.

Verification

  • Formatter dry run over the whole tree (throwaway clone, aggregate installed, every tracked file staged, each formatter job alone): every rewrite landed in the cleanup PR; nothing else changes.
  • lefthook dump lists the remote's jobs, and where skipped, typos and markdownlint with skip: true and gitleaks without.
  • This commit ran the aggregate's pre-commit, commit-msg and pre-push jobs.

Related

🤖 Generated with Claude Code

Name claude-code-plugins' root lefthook-remote.yml, which extends all 11
hook plugins' remote configs, in place of the guardrails-only config, and
list the formatter cleanup commit in .git-blame-ignore-revs. Where the
standards base fragment is extended, skip its typos and markdownlint
lanes, which the remote's spelling and markdown-format jobs duplicate;
gitleaks stays.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T10:11:12.129584Z 09ca8b6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 09ca8b61ba48e9dc8427993e362e5bcc1a031128: 0 finding(s), 0 as inline comments.

No security findings in this PR (2 files: .git-blame-ignore-revs, lefthook.yml).

  • lefthook.yml: The only change is the remote config path, from plugins/guardrails/git-hooks/lefthook-remote.yml to lefthook-remote.yml. The remote (https://github.com/melodic-software/claude-code-plugins), ref: main and refetch_frequency: 24h are unchanged. The path change itself widens no trust, adds no new external source and moves no pin. The file is not a listed trust control or merge hold. The unpinned ref: main remote was already in place, so it is out of scope as a pre-existing condition. I could not read the remote's lefthook-remote.yml, so I did not judge what hooks it defines. That content is controlled upstream by the same owner org.
  • .git-blame-ignore-revs: This new file only lists a commit SHA for git blame. It has no execution path. Nothing is read from it unless a clone opts in with git config blame.ignoreRevsFile, and its only effect is on blame display.

I checked neither file for Actions, manifest or userConfig changes. The PR has none. No manifest lines, uncovered rules or holds apply.

critical-findings: 0

@github-actions

Copy link
Copy Markdown

claude-review reviewed 09ca8b61ba48e9dc8427993e362e5bcc1a031128: 0 finding(s), 0 as inline comments.

No findings. I read the full diff (lefthook.yml and a new .git-blame-ignore-revs) and the PR context.

  • lefthook.yml: configs: now names lefthook-remote.yml, with ref and refetch_frequency unchanged. I could not confirm that lefthook-remote.yml exists on claude-code-plugins main: a gh api call to check it was blocked by the sandbox approval prompt. That is unverified, and the PR's lefthook dump and hook-run claims are author-claimed and unverified.
  • .git-blame-ignore-revs: The listed SHA 410d843 resolves in the repo as "style: apply the bash-format formatter to the tree (style: apply the bash-format formatter to the tree #176)" and is on origin/main. git merge-base --is-ancestor reported it as not an ancestor of HEAD, but HEAD is a parentless, shallow checkout, so that result says nothing about the PR.
  • PR description vs diff: The Fix section mentions per-command skip: true on typos and markdownlint "where lefthook.yml extends the standards .lefthook/base.yml". The checked-out lefthook.yml has no such extension and there is no .lefthook/ directory, so that clause does not apply here and nothing is missing from the diff.
  • Closing issue: None. The PR uses the no-issue escape, so there are no criteria to check.
  • Loosened checks: No loosened_check_verdict: line was supplied, so I used the default fail with no consumer entries. The diff loosens no check; it adds hook jobs and a blame-ignore file.
  • Manifests: The diff touches no plugin manifests.
  • Test coverage: The change is CI/config only and the sync-local suite is unaffected.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit 6754032 into main Nov 18, 2026
12 checks passed
@kyle-sexton
kyle-sexton deleted the ci/lefthook-aggregate-remote branch November 18, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant