Skip to content

chore(ecosystems): drop tool versions copied from ci-workflows - #179

Merged
kyle-sexton merged 1 commit into
mainfrom
chore/ecosystems-drop-copied-versions
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
chore/ecosystems-drop-copied-versions

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/control-hub#17

Summary

Row 2 of control-hub#17: the ecosystem records copied tool versions from ci-workflows by hand, and the copies drift. The owner decided (2026-11-18) to delete the copies and keep a tool-pin entry only where this repository owns the version. Here none is owned, so every pin goes.

Fix

Tool File Decision Source of the version
lychee cross-cutting.yaml (tool-pin, install-hint, a recheck sentence in notes) deleted ci-workflows .github/actions/lychee-offline/action.yml:20-27 (version, sha256 defaults); pr-require-checks.yml:254-256 passes only config:
typos cross-cutting.yaml (tool-pin, install-hint) deleted ci-workflows .github/actions/typos/action.yml:44-49; pr-require-checks.yml:271-274 passes only config: and hidden:
gitleaks cross-cutting.yaml (tool-pin, install-hint, version and checksum line refs in notes) deleted ci-workflows .github/actions/gitleaks/action.yml:50-57; no job here installs gitleaks
none bash.yaml, markdown.yaml, powershell.yaml, typescript.yaml, yaml.yaml removed empty tool-pin: {} n/a

Hints now name the action that pins the version, without the number. Commands, globs, opt-ins and notes on unpinned tools (shellcheck, PSScriptAnalyzer) are unchanged.

Verification

  • yq . parses all six records.
  • The repository has no schema check for .claude/ecosystems/ (git grep finds no reader outside the records).
  • Pre-commit, commit-msg and pre-push hooks passed.
  • Left out: the CI suites (shellcheck, sync-local, manifest validation), which read no .claude/ecosystems/ file; CI runs them.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

The lychee, typos and gitleaks versions and checksums in
cross-cutting.yaml restated ci-workflows' composite-action defaults,
which this repository does not override. Hints now name that source
without the number, and empty tool-pin keys are gone.

Refs melodic-software/control-hub#17

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 18, 2026 23:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T23:31:01.789873Z 8f0121e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 8f0121e1b8a3d2e6cfa7b5fadd1d361991dd5876: 0 finding(s), 0 as inline comments.

No findings. I reviewed all six files in .claude/ecosystems/ from the full diff.

What the change does. It deletes the hand-copied lychee 0.24.2, typos 1.50.3 and gitleaks 8.30.1 pins and their SHA-256 values from the cross-cutting.yaml tool-pin map and install-hint. It also removes the empty tool-pin: {} from the other five records. The edits are consistent across the files:

  • Install hints: these now say "at the version ci-workflows' pins" and keep the winget/brew commands.
  • cross-cutting.yaml notes: the sentence telling readers to compare tool-pin with the action defaults on a Dependabot bump is gone, along with the gitleaks version and checksum line refs. Nothing in the notes still refers to the removed tool-pin values.
  • bash.yaml and powershell.yaml notes: they still say "No tool-pin: …". That wording is accurate, because those records own no pin.

Closing issue. The PR only references melodic-software/control-hub#17 ("Refs:"). No ## Closing issue section was provided in the context file, so there are no acceptance criteria to check. That issue is unread, not met.

Not checked.

  • I could not confirm that no consumer requires the tool-pin key to be present. The consumer is the ecosystem-commands contract in claude-code-plugins' toolchain, which is outside this repository. The author's git grep finds no reader here, and I did not check the consumer.
  • No .claude/rules/ directory exists, so there are no path-scoped rules to apply.
  • The wrapper gave no settled-threads or prior-findings file, so nothing is settled or prior.
  • No loosened_check_* lines were supplied. I used the fail verdict with no consumer entries. Nothing in the diff loosens a check, since it only edits YAML data.
  • I ran no tests. This is a YAML data change, and the author's yq parse check is author-claimed and unverified by me.

Loosened-check verdict: fail, with no consumer entries, as defaulted above. It raises no finding.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 8f0121e1b8a3d2e6cfa7b5fadd1d361991dd5876: 0 finding(s), 0 as inline comments.

No security findings in this pull request.

Scope. The PR touches six files under .claude/ecosystems/*.yaml. It drops the tool-pin key from all six and rewrites the lychee, typos and gitleaks entries in cross-cutting.yaml to say "at the version ci-workflows' action pins" instead of quoting version numbers and SHA-256 checksums.

What I checked.

  • Commands: none of the executable fields (check-cmd, test-cmd, fix-cmd) changed. The check-cmd in cross-cutting.yaml already ran lychee, typos and gitleaks from PATH without referencing tool-pin.
  • Consumers: tool-pin is read by nothing in this repository. A grep for it finds only the six record files plus the lane's own diff and PR checkout copies. The key was empty ({}) in four of the files.
  • Install hints: the removed lines were human-readable install-hint and notes text. Nothing here installs or downloads a binary or verifies a checksum. The CI pins in pr-require-checks.yml and the ci-workflows composites are not part of this diff.
  • Other surfaces: the diff touches no workflow, trusted-actor list, token request, kill switch, merge hold, plugin manifest or marketplace file. It deletes no standing instruction such as CLAUDE.md, AGENTS.md, a rules file, a skill or agent body, or a hook allowlist. It adds no new secret handling.
  • Embedded instructions: I found none in the diff text.

Dropped version and checksum text. The deleted text was a documentation copy of pins that live upstream. A developer installing these tools locally from the hint now gets whatever version their package manager provides, but that does not widen what CI runs, and the notes state it. I report it as noise, not a finding.

critical-findings: 0

@kyle-sexton
kyle-sexton merged commit a89ba39 into main Nov 18, 2026
14 checks passed
@kyle-sexton
kyle-sexton deleted the chore/ecosystems-drop-copied-versions branch November 18, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant