Skip to content

fix(pr-convention-policy): recognize callers on the report-ci-status composite #1065

Closed

Description

@kyle-sexton

The report-ci-status composite (ci-workflows#1139, v0.76.0) replaces a caller's direct check-contract step; it calls check-contract through $/ at the commit the caller pins. Two checks here find a caller's contract only by a direct uses: .../pr-require-checks/check-contract@<sha> line, so neither sees a migrated caller.

What breaks

  1. The caller-pin audit (maintenance-audit-pr-convention-pins.yml, every push to main, weekly, dispatch). detectArtifactPin in components/pr-convention-policy/lockstep-drift.mjs matches only COMPOSITE_PIN_PATTERN (check-contract@<sha|main>), the local form and the pr-issue-linkage.yml reusable. A caller on report-ci-status matches none, so the scan reports caller <repo>: no check-contract composite step and no pr-issue-linkage caller. songwriting#75 (merged 2026-11-18 20:16 UTC) and codex-plugins#208 (merged 20:19 UTC) are already migrated. The last audit run, 44333503754 at 15:15 UTC, predates both, so the next push to main here, or Wednesday's 07:29 UTC run, is expected to fail. Open migrations: cursor-plugins#178, knowledge-corpus#77, and the rest of the ci-workflows#1138 rollout.
  2. This repository's own migration. components/commit-convention/commit-convention.test.sh (lines 89-95) reads the check-contract@<sha> pin out of .github/workflows/pr-require-checks.yml to fetch the types default. Once this repository's ci-status moves to report-ci-status, the sed finds no pin and pr-require-checks.yml pins one check-contract SHA fails in Check PR Convention Copies. The migration therefore needs this test changed in the same PR, which the rollout brief (edit only the workflow file) did not plan for.

Fix

  • detectArtifactPin: also match uses: melodic-software/ci-workflows/.github/actions/pr-require-checks/report-ci-status@<sha> and treat it as kind: "composite" at that SHA. check-contract exists at the same SHA, and report-ci-status runs it there, so the existing per-pin contract check applies unchanged. Add fixture cases to lockstep-drift.test.mjs.
  • commit-convention.test.sh: accept either pin (check-contract or report-ci-status) and fetch check-contract/action.yml at that SHA.

Land this before the next push to main here, or the pin audit goes red on the two callers already migrated.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions