Skip to content

ci: move ci-status onto the shared report-ci-status composite - #1067

Merged
kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status-composite
Nov 18, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
ci/report-ci-status-composite

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: a rollout step of melodic-software/ci-workflows#1138, which stays open until every repository has migrated.

Summary

Rollout of ci-workflows#1138: the ci-status job now runs the shared report-ci-status composite (ci-workflows#1139, v0.76.0) instead of its own check-contract and aggregate-results steps. CI Status stays the job's name and the single required check. Worked examples copied: songwriting#75 and codex-plugins#208. Merge after #1066, which teaches the fleet pin audit the same pin.

Fix

  • ci-status steps: one report-ci-status step, then a "Fail on the contract or draft policy" step that fails on any outcome other than success, so an empty or renamed output fails closed. The composite step keeps the name Aggregate lane results, as step-name did before.
  • Behavior kept:
    • draft: allow: the workflow is not draft-gated.
    • exempt-authors: 'dependabot[bot]'.
    • treat-skipped-as at the composite's default fail, the value set before.
    • The job's if: !cancelled(), needs, permissions, runner and timeout-minutes: 8 are unchanged.
  • Concurrency: unchanged; a push already falls back to github.run_id.
  • Comments describe what the composite fixes (yield-to-full-run: 'true', carry-forward-wait-seconds: '0', action.yml L128-L129) instead of inputs the file no longer sets.
  • components/commit-convention/commit-convention.test.sh read the check-contract@<sha> pin from this workflow to fetch the types default, and would have failed Check PR Convention Copies with no such pin. It now accepts the report-ci-status@<sha> pin too: that composite runs check-contract through $/ at its own commit, so the test still fetches check-contract/action.yml at that SHA.
  • Lines (git diff --numstat): workflow 31 removed, 35 added; commit-convention.test.sh 3 removed, 5 added.

Verification

  • actionlint .github/workflows/pr-require-checks.yml: no findings.
  • The test's new sed on this branch's workflow prints ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f; bash -n on the test passes. The full test runs in this PR's Check PR Convention Copies lane.

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C

The contract check and lane aggregation become one report-ci-status step
pinned at ci-workflows v0.76.0, with a step that fails the job on the
contract or draft output. The draft policy stays allow, dependabot[bot]
stays exempt and treat-skipped-as stays fail. Concurrency already falls
back to github.run_id.

The commit-convention test read the check-contract pin from this
workflow; it now accepts the report-ci-status pin too, since that
composite runs check-contract at the commit it is pinned to.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vcupoo79EqmECYFZ4MTv6C
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 18, 2026 20:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T20:39:43.309071Z 8d508d1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

claude-review reviewed 8d508d1de45876fcf0f7c054f63ec1442e90f9e5: 0 finding(s), 0 as inline comments.

No findings on this pull request (two files: .github/workflows/pr-require-checks.yml and components/commit-convention/commit-convention.test.sh).

What I checked

  • Workflow change: the ci-status job swaps its check-contract and aggregate-results steps for one report-ci-status@ebd0e3b… step and a new "Fail on the contract or draft policy" step. exempt-authors, the Aggregate lane results step name, the job's if, permissions and timeout are all preserved. The new fail step checks != 'success' on both outputs, so an empty or renamed output fails closed, as the PR says. I found no spot where the job now accepts something it rejected before.
  • Test change: the widened sed pattern matches the one report-ci-status@<sha> line in the workflow and yields a single 40-hex SHA. I found no other file in the repo that reads the check-contract@ pin, the aggregate-results pin, or the removed inputs. The aggregate-results mentions left in naming-lint.test.mjs and the conventions README are unrelated naming examples.
  • Rule file: .claude/rules/pr-body-contract.md has no paths: frontmatter that matches the change. The PR body opens with No related issue: <reason> and fills Summary, Fix, Verification and Related, as the rule asks.

Not verified

  • I could not read the report-ci-status composite. gh api was blocked in this sandbox. I therefore did not confirm that the composite declares the draft input or the contract and draft outputs, that it fixes yield-to-full-run: 'true' and carry-forward-wait-seconds: '0', or that it runs check-contract at its own commit through $/. The PR cites those as author-claimed (action.yml L128-L129 and the two worked examples). Its actionlint run and the sed output are likewise author-claimed. The Check PR Convention Copies lane in this PR's CI is what will exercise the test change.
  • Merge order: the PR says to merge after fix(pr-convention-policy): recognize callers on the report-ci-status composite #1066, which teaches the fleet pin audit the new pin. This is an ordering dependency outside the diff and I did not check it.

Loosened-check verdict: fail (no wrapper settings lines, defaults used); patterns: 0. The decision-record line was absent, so the citation requirement was not checked. No loosening found: nothing is skipped, removed or set to soft-fail, and the draft policy is stated as allow, matching the workflow's lack of a ready_for_review trigger.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown

claude-security-review reviewed 8d508d1de45876fcf0f7c054f63ec1442e90f9e5: 0 finding(s), 0 as inline comments.

Security review: no findings

critical-findings: 0

Scope. The pull request changes two files. .github/workflows/pr-require-checks.yml replaces the check-contract and aggregate-results steps with the single report-ci-status composite. components/commit-convention/commit-convention.test.sh relaxes a pin-extraction regex.

What I checked

  • Pin. The new uses: line pins ci-workflows/.../report-ci-status to a full 40-character SHA, ebd0e3bed99ae1365fcb4ef47ce97cfa745fcf2f, from the same org. That is not an unpinned or loosened pin. I could not confirm that the SHA matches the v0.76.0 tag. gh api calls to ci-workflows were blocked in this sandbox. I also could not read the composite's action.yml to check the claimed fixed inputs: yield-to-full-run: 'true', carry-forward-wait-seconds: '0', and the default token.
  • Token scope. The job's permissions: block is unchanged (actions: write, contents: read, and so on). The old steps passed token: ${{ github.token }} explicitly. The new step passes no token:, so the composite's default applies. A composite cannot receive anything wider than the job's GITHUB_TOKEN, so the token's scope does not grow.
  • Trusted-actor widening. exempt-authors: 'dependabot[bot]' is carried over as an exact-login match. The exempt set is unchanged.
  • Gate fail-closed behaviour. The new step Fail on the contract or draft policy fails unless both steps.report.outputs.contract and steps.report.outputs.draft equal success. An empty or renamed output therefore fails the job, and the contract result still gates the job. if: ${{ !cancelled() && ... }} preserves the old !cancelled() behaviour.
  • Draft policy. draft: allow is justified in the workflow by the lack of a ready_for_review trigger. This is a throughput-phase friction setting, not a token, secret, or trusted-actor change. A draft pull request still runs every lane and the contract check.
  • Injection. The new run: block echoes a constant string. It interpolates no github context values, so there is no expression-injection surface.
  • Test script. The changed regex only widens which uses: lines the pin-consistency test recognises, check-contract or report-ci-status. The test still requires exactly one 40-hex SHA and later fetches the check-contract action at that pin. It runs no untrusted input, and no control is weakened.

Trust-control note. .github/workflows/pr-require-checks.yml contains the ci-status hold steps, so I read its whole change. The hold semantics are unchanged: the contract and lane aggregation still fail the job, and a contract-only run still yields to a full run and re-runs once the full run succeeds. No hold is weakened, and the gate stays fail-closed.

No Actions-specific finding needs reasoning beyond zizmor's lane. I recorded no manifest, plugin, or instruction-surface items.

@kyle-sexton
kyle-sexton merged commit 715bb6f into main Nov 18, 2026
24 checks passed
@kyle-sexton
kyle-sexton deleted the ci/report-ci-status-composite branch November 18, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant