Repository navigation
feat(claude-lanes): migrate hosted review callers to pr-review-cli.yml - #1086
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #1086, incremental (29dfaf7 → 29538b7)No security issues found. This review covered only the new changes and reported only blocking findings, because this lane already reviewed head I read every hunk of both files changed since the last review, in
Trust controls. Neither file is a trusted-path or hold-path control: not the trusted-trigger check, the token broker, the kill switch or the merge holds. No standing instruction is deleted or softened, and no plugin manifest is touched. Prior findings. The earlier review of this PR had 0 findings, so nothing carries over. The PR description contains no instructions aimed at the lane. critical-findings: 0 |
|
claude-review reviewed Code review (new commits since
|
…d clarify check-name comment
Refs: melodic-software/control-hub#13
Summary
Migrates the public-repository Claude review callers —
components/claude-lanes-hosted/(synced to.github,agent-plugins,ci-runner,claude-code-account-rotation,codex-plugins, andcursor-plugins) andstandards's own repo-local.github/workflows/pr-review.ymland.github/workflows/pr-review-security.yml— from the legacy OAuth-onlypr-review.yml/pr-review-security.ymlreusables ontomelodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@main.This moves all seven public repositories onto key-first credential routing (
REVIEWS_CLAUDE_API_KEY, thenREVIEWS_CLAUDE_CODE_OAUTH_TOKEN, thenFALLBACK_CLAUDE_CODE_OAUTH_TOKEN). Per owner direction (A2, keeping$0hosted billing for private fleet-enrolled repos),components/claude-lanes/stays on the self-hosted fleet callers until self-hosted isolation support is added toci-runnerandpr-review-cli.yml.Fix
components/claude-lanes-hosted/claude-review.yml,components/claude-lanes-hosted/claude-security-review.yml,.github/workflows/pr-review.yml, and.github/workflows/pr-review-security.yml:uses:tomelodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@main.lane: code/lane: securityandpublish: comments, dropping the removedrunnerandfallback-credential-nameinputs.docs-only-paths(docs/**/*.md,**/README.md,**/CHANGELOG.md) explicitly on both security callers to preserve the legacy security reusable's docs-only skip behavior (pr-review-cli.ymldefaults empty).actions: read,checks: read,contents: read,pull-requests: writeand dropid-token: write.CLAUDE_API_KEY,CLAUDE_CODE_OAUTH_TOKEN, andFALLBACK_CLAUDE_CODE_OAUTH_TOKENmapped to the orgREVIEWS_*/FALLBACK_*secrets matchingcomponents/runner-policy/policy.json.components/runner-policy/runner-policy.test.mjsto assert thepr-review-cli.ymlcontract, permissions, secrets, job IDs, andHostedworkflow names.distribution/sync-manifest.ymlanddistribution/README.mdprose forcomponents/claude-lanes-hosted/.Verification
node --test components/runner-policy/runner-policy.test.mjs: 247/247 passed.node --test components/trusted-actors/trusted-actors.test.mjs: 7/7 passed.node components/runner-policy/runner-policy.mjs --root .: passed.node components/concurrency-policy/concurrency-policy.mjs --root .: passed.node components/github-actions-conventions/naming-lint.mjs --root . --mode enforcing: 0 findings.npm run lint:md: 0 issues across 136 files.biome check --config-path biome.jsonc components/runner-policy/runner-policy.test.mjs: 0 errors.typosandeditorconfig-checkeron all modified files: 0 issues.ci-gaterequires onlyCI Status; agentic reviews remain advisory per ADR 0011).Related