Skip to content

feat(claude-lanes): migrate hosted review callers to pr-review-cli.yml - #1086

Merged
kyle-sexton merged 2 commits into
mainfrom
feat/migrate-hosted-review-lanes-to-pr-review-cli
Nov 21, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
feat/migrate-hosted-review-lanes-to-pr-review-cli

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

Refs: melodic-software/control-hub#13

Summary

Migrates the public-repository Claude review callers — components/claude-lanes-hosted/ (synced to .github, agent-plugins, ci-runner, claude-code-account-rotation, codex-plugins, and cursor-plugins) and standards's own repo-local .github/workflows/pr-review.yml and .github/workflows/pr-review-security.yml — from the legacy OAuth-only pr-review.yml / pr-review-security.yml reusables onto melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@main.

This moves all seven public repositories onto key-first credential routing (REVIEWS_CLAUDE_API_KEY, then REVIEWS_CLAUDE_CODE_OAUTH_TOKEN, then FALLBACK_CLAUDE_CODE_OAUTH_TOKEN). Per owner direction (A2, keeping $0 hosted billing for private fleet-enrolled repos), components/claude-lanes/ stays on the self-hosted fleet callers until self-hosted isolation support is added to ci-runner and pr-review-cli.yml.

Fix

  • Updated components/claude-lanes-hosted/claude-review.yml, components/claude-lanes-hosted/claude-security-review.yml, .github/workflows/pr-review.yml, and .github/workflows/pr-review-security.yml:
    • Switch uses: to melodic-software/ci-workflows/.github/workflows/pr-review-cli.yml@main.
    • Set lane: code / lane: security and publish: comments, dropping the removed runner and fallback-credential-name inputs.
    • Pass docs-only-paths (docs/**/*.md, **/README.md, **/CHANGELOG.md) explicitly on both security callers to preserve the legacy security reusable's docs-only skip behavior (pr-review-cli.yml defaults empty).
    • Grant actions: read, checks: read, contents: read, pull-requests: write and drop id-token: write.
    • Pass CLAUDE_API_KEY, CLAUDE_CODE_OAUTH_TOKEN, and FALLBACK_CLAUDE_CODE_OAUTH_TOKEN mapped to the org REVIEWS_* / FALLBACK_* secrets matching components/runner-policy/policy.json.
  • Updated the hosted-caller contract test in components/runner-policy/runner-policy.test.mjs to assert the pr-review-cli.yml contract, permissions, secrets, job IDs, and Hosted workflow names.
  • Reconciled distribution/sync-manifest.yml and distribution/README.md prose for components/claude-lanes-hosted/.

Verification

  • node --test components/runner-policy/runner-policy.test.mjs: 247/247 passed.
  • node --test components/trusted-actors/trusted-actors.test.mjs: 7/7 passed.
  • node components/runner-policy/runner-policy.mjs --root .: passed.
  • node components/concurrency-policy/concurrency-policy.mjs --root .: passed.
  • node components/github-actions-conventions/naming-lint.mjs --root . --mode enforcing: 0 findings.
  • npm run lint:md: 0 issues across 136 files.
  • biome check --config-path biome.jsonc components/runner-policy/runner-policy.test.mjs: 0 errors.
  • typos and editorconfig-checker on all modified files: 0 issues.
  • Audited org rulesets (ci-gate requires only CI Status; agentic reviews remain advisory per ADR 0011).

Related

  • melodic-software/control-hub#13

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T19:51:28.025064Z 29dfaf7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

claude-security-review reviewed 29538b7f5204b0be5a39d34a1da5b888befe6919: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #1086, incremental (29dfaf7 → 29538b7)

No security issues found. This review covered only the new changes and reported only blocking findings, because this lane already reviewed head 29dfaf7.

I read every hunk of both files changed since the last review, in .claude-lane/incremental.diff:

  • components/claude-lanes-hosted/claude-review.yml: only the header comment changed. It now says the hosted caller reports PR Review / Publish Review while the fleet sibling still reports PR Review / Claude. The triggers, permissions, secrets, uses: and with: inputs did not change, so no token scope, trusted actor or untrusted-text path moved.

  • components/runner-policy/runner-policy.test.mjs: the hosted-caller test gets stricter. It now checks that each hosted caller matches its fleet sibling on:

    • on triggers, top-level permissions and concurrency
    • the job's name and if
    • allowed-bot-sender-ids and allowed-author-ids

    It also pins docs-only-paths on the security lane to docs/**/*.md, **/README.md, **/CHANGELOG.md. Those checks lock the trigger and trust inputs to the fleet sibling's values, so a hosted caller can't quietly drift wider. Nothing is loosened.

Trust controls. Neither file is a trusted-path or hold-path control: not the trusted-trigger check, the token broker, the kill switch or the merge holds. No standing instruction is deleted or softened, and no plugin manifest is touched.

Prior findings. The earlier review of this PR had 0 findings, so nothing carries over.

The PR description contains no instructions aimed at the lane.

critical-findings: 0

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude-review: 2 inline finding(s) on 29dfaf7805e58f5fe55069f8d07dffea94d6cfa0; the summary is in this lane's pull request comment.

claude-lane: claude-review

@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

claude-review reviewed 29538b7f5204b0be5a39d34a1da5b888befe6919: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Code review (new commits since 29dfaf7): blocking findings only

This lane already reviewed an earlier head of this pull request, so this review reports blocking findings only. It covers the two files changed since 29dfaf7: components/claude-lanes-hosted/claude-review.yml and components/runner-policy/runner-policy.test.mjs.

Both findings from the last review are fixed:

  • Loosened check (blocking last time): the hosted-caller test checks parity with the fleet callers again for everything the two still share. It now asserts that each hosted caller matches its fleet sibling in triggers (on), top-level permissions, concurrency, job name, job if, allowed-bot-sender-ids and allowed-author-ids (runner-policy.test.mjs#L6654-L6677). It also pins the security caller's docs-only-paths to the old default (#L6686-L6692). I compared these assertions with the four caller files at head, and each one matches. For example, neither security caller sets allowed-author-ids, so both sides are undefined. The YAML literal block for docs-only-paths parses to "docs/**/*.md\n**/README.md\n**/CHANGELOG.md\n" (the trailing newline is kept), which matches the expected string. I did not run the test suite. The 247/247 pass count is the author's claim and is unverified.
  • Check-name comment (important last time): the header comment in components/claude-lanes-hosted/claude-review.yml no longer claims the check name is the same on every target. It now says the hosted caller reports PR Review / Publish Review and the fleet caller still reports PR Review / Claude. Its claim that "the org's review-lane check lists accept both" is about org settings outside this repository, so I could not check it.

No new blocking findings.

Advisory and manifest lines (1)
  • Loosened checks would be marked: fail (default: the prompt has no loosened_check_verdict: / loosened_check_patterns: line); patterns: 0. The prompt has no loosened_check_decision_record: line, so the citation requirement was not checked. This push adds assertions and removes none, so it loosens no check.

Other notes:

  • Paved paths: the earlier review found no standards index, and this push changes no file that would add one.
  • No closing issue is linked (the description has only Refs:), so no acceptance criteria apply.
  • A security lane runs in this repository, so this review leaves security findings to it.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton merged commit e1268d3 into main Nov 21, 2026
34 checks passed
@kyle-sexton
kyle-sexton deleted the feat/migrate-hosted-review-lanes-to-pr-review-cli branch November 21, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant