Fix crash when OpenRouter sends chunks with empty choices array#65
Open
rmichelena wants to merge 1 commit intomeltylabs:mainfrom
Open
Fix crash when OpenRouter sends chunks with empty choices array#65rmichelena wants to merge 1 commit intomeltylabs:mainfrom
rmichelena wants to merge 1 commit intomeltylabs:mainfrom
Conversation
Use optional chaining on choices[0].delta.tool_calls to guard against chunks (e.g. usage/close chunks) that have no choices, which caused "undefined is not an object" errors for all OpenRouter streaming calls. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
choicesis an empty array (e.g. final usage/close chunks, as documented in OpenRouter streaming + OpenAIstream_options.include_usage).OpenAICompletionsAPIUtils.tswas unconditionally accessingchunk.choices[0].delta.tool_calls, crashing withundefined is not an objecton every OpenRouter streaming call that includes those chunks.chunk.choices?.[0]?.delta?.tool_calls || []so empty-choices chunks are silently skipped.Test plan
by-claude