Skip to content

helpers: Add option to build MW at specific revisions#288

Open
JamiKettunen wants to merge 2 commits into
mer-hybris:masterfrom
sailfishos-oneplus5:build-revisions
Open

helpers: Add option to build MW at specific revisions#288
JamiKettunen wants to merge 2 commits into
mer-hybris:masterfrom
sailfishos-oneplus5:build-revisions

Conversation

@JamiKettunen

Copy link
Copy Markdown
Contributor

The devel repos for many packages can move fast at times and cause breakages when building againt the current latest SFOS release, so having a convenient switch to quickly checkout a specific revision of a middleware component simply makes sense.

This works for both git tags as well as commit hashes.

Comment thread helpers/build_packages.sh Outdated
Comment thread helpers/util.sh
@JamiKettunen

Copy link
Copy Markdown
Contributor Author

Would it make sense to also git clean -df when switching revision? I know some building some packages leaves residue files in-tree that could potentially cause issues when building another version of the package.

@JamiKettunen
JamiKettunen requested a review from Thaodan December 15, 2021 13:38
Comment thread helpers/util.sh Outdated
The devel repos for many packages can move fast at times and cause
breakages when building againt the current latest SFOS release, so
having a convenient switch to quickly checkout a specific revision of a
middleware component simply makes sense.

This works for both git tags as well as commit hashes.
Without this any submodules could get out of sync.
@0312birdzhang

Copy link
Copy Markdown
Contributor

I would ask when will this pr merged?
On 5.0.0.29 hybris-14.1 armv7hl base, the lastest geoclue-providers-hybris failed to build and the lastest sensorfw failed to start.
Really need specific revisions support on MW, not some hacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants