Move to_petsc_local_numbering into Animate#226
Merged
joewallwork merged 13 commits intomainfrom Feb 24, 2026
Merged
Conversation
joewallwork
added
enhancement
Collaborator
|
This works indeed for me locally. I think this should work with mesh-adaptation/docs#173 |
Member
Author
|
This is now ready for review. I added a very basic proof-of-life unit test. We can build on it as a follow-up PR. |
stephankramer
approved these changes
Feb 24, 2026
Collaborator
stephankramer
left a comment
stephankramer
left a comment
There was a problem hiding this comment.
Perfect, many thanks - makes my life a lot easier
Shall we just merge this first, then I'll rebase #228 on main and indeed add a more meaningful (parallel!) test before merging into main?
Member
Author
Sounds good, will merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #225.
Once this is merged, I'll open a PR to remove
to_petsc_local_numberingfrom Firedrake.