Skip to content

Update hsp-iit.yml#275

Merged
pattacini merged 3 commits into
mesh-iit:masterfrom
lornat75:patch-55
May 19, 2026
Merged

Update hsp-iit.yml#275
pattacini merged 3 commits into
mesh-iit:masterfrom
lornat75:patch-55

Conversation

@lornat75
Copy link
Copy Markdown
Contributor

No description provided.

@lornat75 lornat75 requested a review from pattacini as a code owner May 19, 2026 13:57
@lornat75 lornat75 had a problem deploying to outside_collaborators_environment May 19, 2026 13:57 — with GitHub Actions Error
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the hsp-iit.yml group configuration by adding matteodesanctis2002 and RicDeSa02 to both the everyone and hpc groups. It also removes FrancescoGervino13 from the everyone group and carlo-alessi from the hpc group. Feedback points out a potential inconsistency where FrancescoGervino13 remains in the hpc group despite being removed from everyone, suggesting a need to verify if their access should be fully revoked.

Comment thread groups/hsp-iit.yml
- "LeoGori" #Leonardo Gori
- "carlo-alessi" #Carlo Alessi
- "malcol123" #Martina Columbaro
- "FrancescoGervino13" #Francesco Gervino
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The user FrancescoGervino13 has been removed from the hsp-iit/everyone group but remains in the hsp-iit/hpc group (line 88). If this user is leaving the team or organization, they should likely be removed from all groups to ensure their access is fully revoked.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I'll fix it.

@pattacini pattacini temporarily deployed to outside_collaborators_environment May 19, 2026 15:31 — with GitHub Actions Inactive
@pattacini pattacini temporarily deployed to outside_collaborators_environment May 19, 2026 15:36 — with GitHub Actions Inactive
@pattacini pattacini merged commit 1114263 into mesh-iit:master May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants