Skip to content

[QA] Rename connections report to "Meshery: Connections Lifecycle" #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leecalcote merged 2 commits into from
Aug 3, 2026
Merged

[QA] Rename connections report to "Meshery: Connections Lifecycle" #83

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea35ff1
[QA] Rename connections report to "Meshery: Connections Lifecycle"
marblom007 Aug 3, 2026
9057a97
[QA] De-duplicate the nesting rationale comment
marblom007 Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions allurerc.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,19 @@ const isTestGroup = (labels, groupName) =>

const hasTestGroup = (labels) => labels.some(({ name }) => name === "testGroup");

// Single source of truth for the Connection Lifecycle Test Group value - used
// for both the report display name and the testGroup filter so the two cannot
// drift apart.
// The Connection Lifecycle Test Group VALUE - this is the `testGroup` label
// value the tests emit (Test Plan "Latest" tab, col B), so it is the report's
// FILTER key and MUST match the value tagged at the source (UI specs + CLI
// converter). Do NOT change it to rename the report - the display name is a
// separate constant below.
const CONNECTION_LIFECYCLE_GROUP = "Connection Lifecycle";

// The connection report's DISPLAY name, decoupled from the filter key above so
// the report can be renamed without breaking the testGroup match. The
// "Meshery: " prefix is intentional - see the connections plugin block below
// for the nesting rationale (kept in one place to avoid drift).
const CONNECTION_REPORT_NAME = "Meshery: Connections Lifecycle";
Comment on lines +36 to +40

@marblom007 marblom007 Aug 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. The full nesting rationale now lives only in the connections plugin block; the CONNECTION_REPORT_NAME constant just carries a short pointer to it, so the two can no longer drift.


// --- Transitional epic-based fallback (remove once all connection results
// carry testGroup) -----------------------------------------------------------
// Before this rename the connection report keyed on epic="Kubernetes
Expand Down Expand Up @@ -155,7 +163,16 @@ export default defineConfig({
//
// The plugin key stays `connections` so the published report URL
// (https://qa.meshery.io/connections/) is unchanged; only the display name
// and filter change.
// changes (reportName = CONNECTION_REPORT_NAME, "Meshery: Connections
// Lifecycle"). The filter (isTestGroup "Connection Lifecycle") is unchanged.
//
// Nesting: the "Meshery: " prefix presents this as a Meshery report in the
// dashboard's report picker. Allure 3 reports are flat peer plugins (the
// config `plugins` map has no parent/child relation, and the awesome
// plugin's only hierarchy is intra-report `groupBy`), so a name prefix is
// the supported way to signal that this is a subset of the main Meshery
// report; true report-under-report nesting is not available without folding
// these results into the Meshery report and losing the standalone URL.
//
// Transitional: the isConnectionBehavior (epic) fallback keeps the report
// populated with connection results emitted before the testGroup label
Expand All @@ -167,7 +184,7 @@ export default defineConfig({
connections: {
import: "@allurereport/plugin-awesome",
options: {
reportName: CONNECTION_LIFECYCLE_GROUP,
reportName: CONNECTION_REPORT_NAME,
singleFile: false,
reportLanguage: "en",
open: false,
Expand Down