Repository navigation
feat: add dedicated mesheryctl BATS report - #85
Conversation
Signed-off-by: Zayden369 <abhishekguptadhan26@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds a filtered Allure report for Mesheryctl BATS results. It filters results by ChangesMesheryctl BATS report
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds and documents a dedicated filtered Mesheryctl BATS report. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Maanvi212006
left a comment
There was a problem hiding this comment.
@Zayden369 Please elaborate about the PR in the PR description!
Done. U can check |
There was a problem hiding this comment.
One thing I noticed: bats-to-allure.js seems to let [project=...] or [framework=...] in the test name overwrite the default labels
So if a test has something like [project=CLI-Docs], it may no longer match the new project=mesheryctl AND framework=bats filter and could be missed from the report.
Can we add a test for this case?
|
Good catch @SuryanshGarg04 . The converter lives in The converter now treats The regression test specifically covers
|
|
Took a look at both the filter addition and the fix in meshery/meshery#21863. The On Suryansh's concern: confirmed the fix addresses it properly, Looks ready from here. |
|
Thank you, @SuryanshGarg04 @MU5A @Maanvi212006 for your reviews. 💯 |
|
Thanks for your contribution to Meshery! 🎉
|
|
Thank you @alexquincy, @SuryanshGarg04, @MU5A, and @Maanvi212006 for reviewing and helping improve this contribution. The feedback about the PR description and possible label overrides helped make the dedicated Mesheryctl BATS report more reliable. I appreciate everyone’s guidance and support in getting it merged! |
Notes for Reviewers
Fixes #86
Problem
The existing Mesheryctl quality report combines Bash/BATS end-to-end results with Go unit test results. This makes it harder to inspect BATS results independently.
Changes
allurerc.mjs.project=mesheryctlandframework=bats, excluding Go unit tests.The existing workflow already collects and publishes BATS results, so no CI workflow changes are required. After merge and successful deployment, the new report will be available at https://qa.meshery.io/mesheryctl-bats/.
Validation
node --check allurerc.mjsandgit diff --checkpassed.npm run report:generatecompleted successfully.This validation used sampled existing results; the BATS test suite was not rerun. One sampled BATS result was already marked failed upstream and remained failed in the generated report. Generated reports and sample data are not included in this PR.