feat(template): moves tests & linter fixes#3
Open
vic-unimedia wants to merge 1 commit into
Open
Conversation
Moves checklist above tests so test images don't bloat PR description
71262ea to
dba5552
Compare
| In order to help other team mates in having context of the ticket and knowing which work has been made, it's mandatory to fill all the mandatory (*) sections (that includes replacing the text placeholders to describe properly the ticket). If any of them have not been filled in, the PR is not ready to review, so people will wait to do the review. (remove this note when you're sure all of the reqs. are fulfilled) | ||
|
|
||
| ## (*)Description | ||
| ## **Description** |
Member
There was a problem hiding this comment.
try to keep the () here and in the other places you removed it, as the description above explains that fields highlighted with the () are mandatory to be filled, so it's important we let people know the "must fill in"s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT
In order to help other team mates in having context of the ticket and knowing which work has been made, it's mandatory to fill all the mandatory (*) sections (that includes replacing the text placeholders to describe properly the ticket). If any of them have not been filled in, the PR is not ready to review, so people will wait to do the review. (remove this note when you're sure all of the reqs. are fulfilled)
(*)Description
Moves testing part to the end in order to avoid clogging PR body with test images & fixes Markdown linter
(*)Type of change
(*)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. For each of the usecases, provide instructions so the team can understand what's been solved in this ticket. Please provide screenshots for each of them, so we know how do you tested for endpoints, bugfixes, etc which are exposed independently if it's an internal GRPC service, public service, etc.
An assertment such as 'make test' shows the test pass will only be enough if we're unit testing a task which was broken into smaller unit pieces (i.e. repository, use-case, controller, etc that still is not coupled to the server) that are not coupled/exposed yet. The rest of the tickets will include screenshots showing how the functionality was tested.
(*)Checklist: