Skip to content

test(cli): sample the MediaPlayer root so swizzle proof slice 8 renders it - #13006

Open
astracat-bot[bot] wants to merge 1 commit into
mainfrom
codebunny/fix/test-cli-sample-the-mediaplayer-root-so-swizzle-proof-slice-8-renders-it-54d0af
Open

astracat-bot[bot] wants to merge 1 commit into
mainfrom
codebunny/fix/test-cli-sample-the-mediaplayer-root-so-swizzle-proof-slice-8-renders-it-54d0af

Conversation

@astracat-bot

@astracat-bot astracat-bot Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

validation: ran SWIZZLE_PROOF_ALL=1 pnpm test:node packages/cli/test/swizzle-proof/swizzle-proof.8.test.mjs packages/cli/test/swizzle-proof/samples.test.mjs twice with the fix: 2/2 passed (6/6 tests, slice 8 ejected, type-checked, bundled and server-rendered all 22 targets with 0 failures). Without the fix, the slice-8 command failed 2/2. pnpm exec prettier --check packages/cli/test/swizzle-proof/samples.mjs passed. The Chromium leg (SWIZZLE_PROOF_BROWSER=1) was not run: the browser could not be installed in the fix environment.

What failed

The release-check release-swizzle-proof (8/8) leg (run 44610467395, commit 0bfa86c) failed packages/cli/test/swizzle-proof/swizzle-proof.8.test.mjs with a single swizzle-proof failure:

lab__MediaPlayer [sample] swizzle target lab__MediaPlayer has no sample in samples.mjs, and its doc gives no default for its required prop(s) label

Cause

e2b63ae (#9832) added the lab media-player family. It added samples for every part (lab__MediaPlayerElement, lab__MediaPlayButton, ...), but not for the root lab__MediaPlayer, which requires label. The proof (spec:AST-110 FR7) cannot render a target with a required prop and no sample, so it reports it by name.

Fix

Add a lab__MediaPlayer sample to packages/cli/test/swizzle-proof/samples.mjs. It renders the ejected root (C) with label: 'Clip' around a video MediaPlayerElement (the ejected module's own export, else the package's), in the same way as the existing media-part samples. This is a test-fixture change only. No component, assertion or exemption changes.

Notes

See also #12991. It makes the same samples.mjs change for the sibling samples.test.mjs failure, and either PR fixes both tests. If #12991 merges first, this one is redundant. I did not run the Chromium render leg locally, so the browser step of this leg is covered only by CI.

#11082 by Rajatendu1 also changes this test file.

#12891 by nynexman4464 also changes this test file.

#12964 by josephfarina also changes this test file.

#12965 by josephfarina also changes this test file.

#12976 by josephfarina also changes this test file.

#12992 by josephfarina also changes this test file.

#12993 by josephfarina also changes this test file.

#13001 by josephfarina also changes this test file.

@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 19, 2026 9:19pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 19, 2026
@astracat-bot

astracat-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor Author

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 19, 2026, 9:24 PM UTC

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI: CI has not finished on this head yet.

The new lab__MediaPlayer sample gives the swizzle proof the root's required label, so the slice-8 proof now passes for every target, on the server and in Chromium, and samples.test.mjs passes where it failed before. #12991 adds the identical entry, and #13001 plus several batch pull requests add a variant at the same line, so only one of them should land.

Claims and files checked

Review mode: full; reason: no-earlier-review

  • Claims:
    • With the fix, the slice-8 proof and the samples test pass for all 22 slice-8 targets: verified by a local run of both on this head (also with the Chromium leg).
    • Without the fix the slice-8 proof fails: verified on the release check at the merge base and by the samples test failing on the base.
    • Prettier accepts the changed file: verified.
    • The release check's slice 8 failed only because the MediaPlayer root had no sample for its required label: verified from that check's failure annotation.
    • The media-player family shipped samples for its parts but not its root, whose doc marks label required: verified in the sample table and the MediaPlayer doc.
    • The proof refuses to render a target with a required prop and no sample: verified in the proof's sample check.
    • The sample renders the copied root with a label around a video element from the copy, else the package, like the part samples: verified.
    • Only a test fixture changes, with no component, assertion or exemption change: verified (one file, nine added lines).
    • A sibling pull request makes the same change, either fixes both tests, and this one is redundant if that lands first: verified (identical patch, both tests read the same sample table).
    • Eight other open pull requests also change this file: verified from each one's file list.
  • Files:
    • packages/cli/test/swizzle-proof/samples.mjs: clear

Automated review (maintainer link)

This branch was successfully deployed

1 active deployment
Preview — db745699 Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants