SEARCH-740 (I): Update mbdata for v30 of the musicbrainz-server schema#71
Merged
reosarevok merged 5 commits intomainfrom May 12, 2025
Merged
SEARCH-740 (I): Update mbdata for v30 of the musicbrainz-server schema#71reosarevok merged 5 commits intomainfrom
reosarevok merged 5 commits intomainfrom
Conversation
reosarevok
force-pushed
the
schema-change-2025-q2
branch
2 times, most recently
from
f1aec5a to
2282e68
Compare
reosarevok
force-pushed
the
schema-change-2025-q2
branch
from
2282e68 to
7907948
Compare
reosarevok
changed the title
yvanzo
reviewed
May 12, 2025
Contributor
yvanzo
left a comment
yvanzo
left a comment
There was a problem hiding this comment.
Thank you for caring about it. Made some comments.
This allows us to pull from temporary branches to update the SQL before the schema change. We default to the latest schema change tag to avoid accidentally pulling in pending master changes.
There's no clear use to keeping the update files around and pushing them to the repo, since they are not used for anything in mbdata and their only use is anyway to carry out schema changes. This also drops the existing contents of the update folder.
Newer versions of poetry only support Python 3.9+.
Run
./scripts/update_sql.sh schema-change-2025-q2
Run
./scripts/update_models.sh
reosarevok
force-pushed
the
schema-change-2025-q2
branch
from
7907948 to
e579247
Compare
yvanzo
approved these changes
May 12, 2025
Contributor
yvanzo
left a comment
yvanzo
left a comment
There was a problem hiding this comment.
Thank you.
(I didn’t test using it.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing
I tested the mbdata (and mb-rngpy) versions when testing metabrainz/sir#160 and it seemed to work well.