Skip to content

Updated ci.yml file and upgraded protocol version#194

Open
miantalha45 wants to merge 2 commits intometacall:masterfrom
miantalha45:updated-ci-protocol-version
Open

Updated ci.yml file and upgraded protocol version#194
miantalha45 wants to merge 2 commits intometacall:masterfrom
miantalha45:updated-ci-protocol-version

Conversation

@miantalha45
Copy link

Summary

Updated ci.yml file for changing the procedure of publishing on npm
upgraded protocol version in package.json

Copilot AI review requested due to automatic review settings February 25, 2026 18:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s npm publishing workflow and bumps the @metacall/protocol dependency version, aligning CI/release behavior with the new publishing approach.

Changes:

  • Bump @metacall/protocol from ^0.1.24 to ^0.1.27 in package.json.
  • Update GitHub Actions workflow permissions and change Node version used in CI.
  • Change npm publishing approach (move away from the previous token-based npm-publish action configuration toward npm publish --provenance).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
package.json Upgrades @metacall/protocol dependency version.
.github/workflows/ci.yml Adjusts workflow permissions, Node version, and the npm publish step/procedure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


- name: Publish
uses: JS-DevTools/npm-publish@v1
uses: JS-DevTools/npm-publish@v2
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow step is invalid because it specifies both uses: and run: in the same step. GitHub Actions requires a step to use either an action (uses) or a shell command (run). Remove uses: JS-DevTools/npm-publish@v2 and keep the run block, or switch back to using the action with appropriate inputs (and no run).

Suggested change
uses: JS-DevTools/npm-publish@v2

Copilot uses AI. Check for mistakes.
token: '${{ secrets.NPM_AUTH_TOKEN }}'
run: |
unset NODE_AUTH_TOKEN
npm publish --provenance
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a scoped package (@metacall/deploy), npm publish commonly requires --access public (or publishConfig.access="public" in package.json) to avoid defaulting to restricted access. The previous workflow explicitly set access: 'public'; consider adding --access public (or publishConfig) back to prevent publish failures on tag builds.

Suggested change
npm publish --provenance
npm publish --access public --provenance

Copilot uses AI. Check for mistakes.
},
"dependencies": {
"@metacall/protocol": "^0.1.24",
"@metacall/protocol": "^0.1.27",
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json is committed and still pins @metacall/protocol to the old range/version, so installs will continue using the locked version (or update the lock locally) despite this package.json bump. Please update and commit package-lock.json to reflect the new @metacall/protocol version so dependency resolution is deterministic and npm ci would remain consistent.

Suggested change
"@metacall/protocol": "^0.1.27",
"@metacall/protocol": "^0.1.26",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants