fix: Apply serverUrl argument to baseURL before API initialization.#196
Open
codxbrexx wants to merge 1 commit intometacall:masterfrom
Open
fix: Apply serverUrl argument to baseURL before API initialization.#196codxbrexx wants to merge 1 commit intometacall:masterfrom
serverUrl argument to baseURL before API initialization.#196codxbrexx wants to merge 1 commit intometacall:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the
--serverUrl(-u) CLI flag had no effect because it was being applied to the configuration after theapiclient was already instantiated.Changes Made
Moved the configuration override block for
--serverUrlto run immediately after startup but beforeAPI()is initialized. This enables developers to target their own local/remote FaaS instances without being restricted to onlylocalhost:9000via the--devflag.Fixes issue #195
Notes
--devflag might become redundant and could potentially be removed in the future now that--serverUrlworks correctly.