Skip to content
This repository was archived by the owner on May 4, 2020. It is now read-only.

Fixes. - #20

Open
izaakschroeder wants to merge 7 commits into
masterfrom
fixes
Open

Fixes.#20
izaakschroeder wants to merge 7 commits into
masterfrom
fixes

Conversation

@izaakschroeder

Copy link
Copy Markdown
Contributor
  • Support styled-components.
  • Better error handler.
  • Fix publicPath.
  • Support prettier.

/cc @wesleycyu

izaakschroeder and others added 7 commits March 15, 2018 03:13
Prettier is a code formatter. It takes code as input and spits out the same code with a prettier format.

It drops most the original styling and formats the code from its syntax tree, the output style is always consistent.

The `test:lint` task asserts that all of the `.js` files match both the current eslint rules and are formatted correctly according to Prettier. It is necessary to run Prettier to reformat any new changes in-place before committing.

**Using Prettier**

Run `npm run format` before committing to reformat any changed code, _or_ configure your editor to automatically run Prettier as files are changed:

**Sublime Text 3:**
  - Install [JsPrettier](https://github.com/jonlabelle/SublimeJsPrettier) (there is not need to install `prettier` globally, the local dependency will be used)
  - Configure JsPrettier to auto format files on save:
  ```json
    // ~/Library/Application Support/Sublime Text 3/Packages/User/JsPrettier.sublime-settings

    {
      "auto_format_on_save": true,
      "auto_format_on_save_excludes": [
        "*/package.json"
      ]
    }
  ```

**Atom:**
 - Install [Prettier for Atom](https://atom.io/packages/prettier-atom)
 - Enable "format on save" (Packages → Prettier → Toggle Format on Save)
Without `cross-loader` finished for `webpack@4` this is the fastest way to get things like `file-loader` working.
In development mode just use the `midori` error handler if everything blows up since it outputs stack traces and all the other good things. Also adds a test for this case.
It tries to parse some invalid JSON coverage file.
Trailing commas are a problem in ES5 files.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants