Skip to content
This repository was archived by the owner on May 4, 2020. It is now read-only.

Add support for flow-runtime. - #8

Open
izaakschroeder wants to merge 3 commits into
masterfrom
flow-runtime
Open

Add support for flow-runtime.#8
izaakschroeder wants to merge 3 commits into
masterfrom
flow-runtime

Conversation

@izaakschroeder

@izaakschroeder izaakschroeder commented Feb 2, 2018

Copy link
Copy Markdown
Contributor

Automagically cast types!

Good: Get runtime type safety for "free" (no additional code writing). Nice errors.
Bad: Performance and/or bundle size.

Comment thread package.json
"find-nearest-file": "^1.1.0",
"flow-runtime": "^0.16.0",
"htmlescape": "^1.1.1",
"immutable": "^3.8.2",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kill it

Comment thread flow-typed/type-defs.js
assert: (input: any) => T,
};
declare var reify: any;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this not have available lib types?!

Comment thread .nvmrc
@@ -1 +1 @@
9
9.4.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update package.json/engines as well

@10xjs

10xjs commented Feb 4, 2018

Copy link
Copy Markdown
Contributor

Would there be any value in using flow-runtime in non-prod builds only? It doesn't look like there is any built in support for this, we would have to roll our own solution (gajus/flow-runtime#36).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants