Repository navigation
FEX build: start Caves of Qud directly, without the Steam client - #757
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #749.
What
On the Arm64 FEX build, every Steam game is handed to the Wine Steam client, so the client starts with each launch. For Caves of Qud (app 333640) it opened full screen every time the game was started. The game doesn't need the client, so on the FEX build it now starts directly:
fex_direct_launch_without_steam(id)lists Caves of Qud.launch.env, as the Steam handoff does, then starts the executable withspawn_direct_game. That's the same direct start Witcher 3 and Elden Ring use on the VKD3D lane, but without theirensure_wine_steam_running, so Steam is neither started nor required.Scope
The change is behind
ms_wine_is_fex(), so the x86_64 build is unchanged. Onlyapp/src-c/runtime/steam_actions.cand its route test change.Testing
make -C app/src-c testpasses, withruntime-routes-testchecking the new list.make -C app/src-c VARIANT=fexbuilds.The issue's second report, Steam reopening after the game is force-stopped, isn't addressed here. With this change the launch no longer starts the client, so it may no longer happen for this game, but that's untested.