fix(i18n): restore the inheriting-royalties anchor on CJK Bubblegum V2 mint pages - #571
Conversation
…2 mint pages #533 linked the ja/ko/zh FAQ answers to `#inheriting-royalties-from-the-collection`, but since #556 those headings take their anchor from the translated text, so the anchor did not exist and the Heading anchors check has failed on main since. Give the three headings an explicit id matching the English slug. This also fixes the 18 links from other ja/ko/zh Bubblegum V2 pages to that anchor.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (3)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. Summary by CodeRabbit
WalkthroughThe Japanese and Korean Bubblegum V2 minting pages add an explicit anchor to the collection royalty inheritance heading. The Chinese page adds a section describing inherited royalties and related DAS and SDK requirements. ChangesLocalized collection royalty documentation
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The translated pages restore the intended heading targets, and the new Chinese guidance is consistent with the repository documentation. No concrete issue remains; the PR is ready to merge subject to normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This branch was successfully deployed
2 participants
Summary
The Heading anchors check has failed on
mainsince #533. The check didn't run on that PR, so every PR that touchessrc/pages/**now inherits the failure (e.g. #570).#533 added an FAQ answer to the ja/ko/zh
bubblegum-v2/mint-cnfts.mdpages that links to#inheriting-royalties-from-the-collection. Since #556, Japanese, Korean and Chinese headings take their anchor from the translated text (## 从集合继承版税becomes#从集合继承版税), so that anchor doesn't exist on those pages.## 从集合继承版税 {% #inheriting-royalties-from-the-collection %}. The translated Bubblegum V2 pages already use this pattern, e.g. jacollections.mdhas## 継承されたロイヤリティ {% #inherited-royalties %}.collections.md,faq.md,hashed-nft-data.md,reading-inherited-royalties.md,sdk/javascript.md) tomint-cnfts#inheriting-royalties-from-the-collection. The audit doesn't report those because it only checks links within a page.Pointing the three FAQ links at the translated anchors instead would pass the check but leave those 18 links broken.
Testing
pnpm run lint:anchorspasses locally: 0 new broken links (452 in the baseline, down from 455).next dev: each translated mint page renders the heading withid="inheriting-royalties-from-the-collection", and the FAQ link points to it.markdownlint-cli2on the changed pages passes.Once this merges, PRs opened before it need their branch updated from
mainfor the check to pass. Re-running the old check reuses the original merge commit.