Conversation
- Remove direct assignment of original name; only camelCase key is used - Normalize by replacing '/' and '_' with '-' before camelCase conversion - Strip `node:` prefix for built-in modules - Remove explicit aliases for childProcess, StringDecoder, perfHooks, asyncHooks, and timers/promises - Add test to ensure no module keys contain forbidden characters (`node:`, `-`, `_`)
tshemsedinov
requested changes
Aug 13, 2026
tshemsedinov
left a comment
tshemsedinov
left a comment
Member
There was a problem hiding this comment.
The direction looks good.
A few changes are needed before merge:
- "name.splice(1)" should be "name.slice(1)"
- The new test doesn't actually check forbidden characters
- I would like to have both normalized and not normalized names
- I suggest making the normalization rule explicit and consistent:
node:fs/promises -> node.fsPromises
node:child_process -> node.childProcess
node:string_decoder -> node.stringDecoder
node:stream/consumers -> node.streamConsumers
Then we can remove all special aliases, including "StringDecoder" and "fsp".
Member
|
Also we do not use semantic commit messages like feat: etc. |
tshemsedinov
changed the title
Member
|
I'll land this after fixes with commit nama: Support namespace prefixes |
tshemsedinov
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node:prefix for built-in modulesnode:,-,_)npm t)npm run fix)