Skip to content

fix for issue #69 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichalW wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix for issue #69 #115

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bc97cd3
Fixed rescheduling jobs when mongodb timed out during execution of job.
Kurounin Sep 9, 2016
a6259ab
fix for issue #69
MichalW Dec 13, 2016
ef39321
Merge remote-tracking branch 'kurounin/master' into HEAD
MichalW Dec 14, 2016
6e0772a
fix
MichalW Dec 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions synced-cron-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,11 +225,11 @@ SyncedCron._entryWrapper = function(entry) {
}
});
} catch(e) {
log.info('Exception "' + entry.name +'" ' + e.stack);
log.info('Exception "' + entry.name +'" ' + (e && e.stack || e));
self._collection.update({_id: jobHistory._id}, {
$set: {
finishedAt: new Date(),
error: e.stack
error: e && e.stack || e
}
});
}
Expand Down Expand Up @@ -263,7 +263,12 @@ SyncedCron._laterSetInterval = function(fn, sched) {
*/
function scheduleTimeout(intendedAt) {
if(!done) {
fn(intendedAt);
try {
fn(intendedAt);
} catch(e) {
log.info('Exception running scheduled job ' + (e && e.stack || e));
}

t = SyncedCron._laterSetTimeout(scheduleTimeout, sched);
}
}
Expand Down