Patch for issue #41

[dalgard]

#41

[zol]

Thanks for you patch @dalgard . Before I'm able to merge it, could you please add some tests around it?

[dalgard]

Can you see my two latest commits under this pull request?

I don't know how to write the code around the call to SyncedCron.add inside the Tinytests. This is as good as I can make it. Also added documentation. Thanks :)

[zol]

You could take a look at synced-cron-tests.js for inspiration. It will take me some time to get around to writing tests against this PR. We have a policy of not merging untested code into our packages.

[dalgard]

Sorry for the late reply. It's a sound attitude, but this library doesn't have the greatest test coverage to begin with and the change is very little – I don't know how to write Tinytests, but with my scaffolding, it will take you very little time.

At any rate, I'm using the patch in production – I really think you should consider it :) Thanks!

[tylerstraub]

In attempting to use the parser.cron method with this forked version, I am experiencing recursive calls during the execution stage of a scheduled job.

With a CRON syntax input such as "58 13 30 4 ? 2015", I am experiencing these results:

SyncedCron.add({
  name: 'Crunch some important numbers for the marketing department',
  schedule: function(parser) {
    // parser is a later.parse object
    return parser.cron('58 13 30 4 ? 2015');
  },
  job: function() {

 /* Anything placed here is firing recursively */

  }
});

What methods for parsing the later.js object have you been successful with in your fork @dalgard?

Thanks!

[dalgard]

I don't really know the cron syntax, I'm using this line in my application:

// Non-recurring
return parser.recur().on(ending_at).fullDate();

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}