2.0 (The React Version)

[methnen]

• Refactored the Admin UI to use React for all of the interface which results in some UI performance and functionality improvements
  • Added a Copy button to the Shortcode input field
  • Height and Force vertical axis minimum fields now resize to fit their contents
• Refactored PHP data parsing code to improve reliability and flexibility with differently formatted data
  • Number values are now parsed to extract prefix and suffix strings allowing data to always be displayed with formatting and localization while still preserving prefixes and suffixes
• Refactored helper code as a Chart.js plugin instead of jQuery
  • Helper code now formats and parses labels as well as tooltips
• Refactored Chart.js template to no longer be reliant on jQuery
• Refactored the Block interface to make some performance and UI improvements
  • Reduced the number of queries required for the interface to function
  • Charts are now lazy loaded into the UI and subsequent charts are loaded as user scrolls
  • Search now accepts any reasonable values you could expect in a post title
  • Show attribute can now be controlled from the block UI
  • Better handling of charts when Chart is missing an image or M Chart performance settings have disabled images
• Lots of additional code modernization and style improvements that didn't effect functionality but should make code easier to maintain going forward
• Fixed an issue where a duplicate localization call could cause localization in the Block ui to not always load

[SevereClimate]

Looks good! Just a couple of notes on potential library usage really, but all seems like a nice logical refactor.

[SevereClimate]

This is fine, but there is a jSpreadsheet React package that gives you the spreadsheet/worksheets as react components more or less ready to use.

[methnen]

Yeah, I thought about that. I should look and see if it makes sense to use it instead.

[methnen]

OK, I remember why I did it this way. It just seemed easier to control the versioning if I'm expressly wrapping the version I've included. I know build scripts can include all of that obviously, but in keeping with my previous practice of managing things like that and the chart.js stuff seperately I decided to keep it outside of the existing React package.

Also, what if I want to maybe do the table rendering later on using Jspreadsheet? Since that could be a useful method and in that case I can't rely on a React package being available to the front end.

[SevereClimate]

it might be worth using the lodash library debounce function for the debouncing here, just to save on wheel reinvention, this is fine though

[methnen]

True, I had a reason I stayed with this, but I can't remember what it was...

[methnen]

OK, I remember this too. My thinking was that I needed to not just debounce for changes, but also cancel requests that were potentially in process. So I mixed the two together so to speak. Maybe that doesn't make sense. But that was the thinking. Maybe I should comment that.