Feat/tf to cdk - #1425
Conversation
| process.env.CORS_ORIGINS || "*", | ||
| DUPLICATES_CLOSE_DATE: process.env.DUPLICATES_CLOSE_DATE || "2024-10-08 00:00 -08:00", | ||
| // Doorway has started using serviceconnect which uses TLS internally, so we can turn HTTPS_OFF on for all environments. | ||
| HTTPS_OFF: process.env.HTTPS_OFF || "true", |
There was a problem hiding this comment.
note: In the new environment "HTTPS_OFF" needs to be set to false
| const listingServiceUrl = runtimeConfig.getListingServiceUrl() | ||
|
|
||
| try { | ||
| logger.info(`requesting URL: ${listingServiceUrl}/${context.params.id}`) |
There was a problem hiding this comment.
note: this is a temporary change while debugging the environment issues
| dayjs.extend(utc); | ||
| dayjs.extend(tz); |
There was a problem hiding this comment.
question: is there a reason these lines were deleted? We added these to add additional options for dayjs
| PGDATABASE: { value: props.databaseName || "bloom" }, | ||
| CLOUDINARY_CLOUD_NAME: { value: "exygy" }, | ||
| CACHE_REVALIDATE: { value: "60" }, | ||
| LANGUAGES: { value: "en,es,zh,vi,tl" }, |
There was a problem hiding this comment.
question: why is the "Languages" and "CLOUDINARY_CLOUD_NAME" variables needed for migrations?
YazeedLoonat
left a comment
YazeedLoonat
left a comment
There was a problem hiding this comment.
got some questions/comments for ya
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
question: we usually use ESLint as our linter, do we need both prettier and eslimnt?
| headers, | ||
| }) | ||
| } catch (e) { | ||
| console.log(e) |
There was a problem hiding this comment.
nitpick: I don't think we want to be logging errors like this for end users
| import { Fn } from "aws-cdk-lib" | ||
| import { ISubnet, Subnet } from "aws-cdk-lib/aws-ec2" | ||
| import { Cluster, FargateService } from "aws-cdk-lib/aws-ecs" | ||
| //import * as ecs from "aws-cdk-lib/aws-ecs"; |
| const pageTitle = `${listing.name} - ${t("nav.siteTitle")}` | ||
| const { profile } = useContext(AuthContext) | ||
|
|
||
| // logger.info(`listing name - ${listing.name}`) |
| // } | ||
|
|
||
| export const getStaticProps: GetStaticProps = async (context: { | ||
| export async function getServerSideProps(context: { |
There was a problem hiding this comment.
question: why are we changing these? we had originally swapped this for performance gains
There was a problem hiding this comment.
@YazeedLoonat this is me trying to debug the issue in the new environment. I don't want to go to serverSideProps, but the static props is causing an issue and I'm trying to track down what is happening
https://exygy.slack.com/archives/C06USRNGSAX/p1762203262538459
| export const getStaticPaths: GetStaticPaths = () => { | ||
| return { paths: [], fallback: "blocking" } | ||
| } | ||
| // export const getStaticPaths: GetStaticPaths = () => { |
There was a problem hiding this comment.
question: same as above
4 participants
This PR addresses #(insert-number-here)
Description
Will be updating this with the additional pipeline steps for staging and prod shortly.
I'll also be commenting code quite a bit.
How Can This Be Tested/Reviewed?
Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: