Skip to content

feat: updated public footer with new phone number - #1449

Draft
millord wants to merge 1 commit into
mainfrom
1436/doorway-public-footer-update
Draft

feat: updated public footer with new phone number#1449
millord wants to merge 1 commit into
mainfrom
1436/doorway-public-footer-update

Conversation

@millord

@millord millord commented Oct 22, 2025

Copy link
Copy Markdown

This PR addresses #1436

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Please include a summary of the change and which issue(s) is addressed.

Navigate to the public site
Scroll to bottom
Footer should look like the figma

image

Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@millord
millord marked this pull request as draft October 22, 2025 19:25
@millord millord changed the title feat(doorway public): updated footer with new phone number feat: updated footer with new phone number Oct 22, 2025

@mcgarrye mcgarrye left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed on hold labels Oct 23, 2025
@ludtkemorgan ludtkemorgan added blocked and removed ready to merge Should be applied when a PR has been reviewed and approved labels Oct 23, 2025
@ludtkemorgan

Copy link
Copy Markdown
Collaborator

@millord this looks good and thanks for making the quick change. But as a heads up we can't merge this until Doorway gives us the go-ahead. So let's just keep this PR open until we can merge

@millord millord changed the title feat: updated footer with new phone number feat: updated public footer with new phone number Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants