Skip to content

fix: exclude paper apps from lottery emails - #1537

Merged
ludtkemorgan merged 2 commits into
mainfrom
fix/lottery-paper
Jun 11, 2026
Merged

fix: exclude paper apps from lottery emails#1537
ludtkemorgan merged 2 commits into
mainfrom
fix/lottery-paper

Conversation

@ludtkemorgan

@ludtkemorgan ludtkemorgan commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

This PR addresses slack message

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

When a partner user submits applications via the partner site they receive an email for each one of those application after the lottery results are published to the public. This PR removes paper apps from being considered. A PR has been created in core that has this change along with test updates

Also there was a missed env variable in the dockerfile for the most recent large Core release causing the Doorway public site to not appear in google searches

How Can This Be Tested/Reviewed?

  1. Seed the data
  2. Create a partner user using your email. Submit at least one application to a lottery listing on the partner site with that account
  3. Create a public user using an email you have access to. Submit an application to the same listing
  4. Login as admin to partner site, close the listing, run the lottery, and release to partners
  5. Login as a partner user that has access to that listing and publish the lottery results to the public
  6. Verify you only receive 1 lottery results email (the one from the public account)

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jun 10, 2026
@ludtkemorgan
ludtkemorgan merged commit 663a305 into main Jun 11, 2026
17 of 19 checks passed
@ludtkemorgan
ludtkemorgan deleted the fix/lottery-paper branch June 11, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants