Skip to content

fix: update warn user of deletion email (bloom-housing#6394) - #1538

Merged
ludtkemorgan merged 2 commits into
mainfrom
1017/warn-user-email
Jun 15, 2026
Merged

fix: update warn user of deletion email (bloom-housing#6394)#1538
ludtkemorgan merged 2 commits into
mainfrom
1017/warn-user-email

Conversation

@ludtkemorgan

Copy link
Copy Markdown
Collaborator

This PR addresses #1536

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Pulls the commit from core related to user deletion email content update

How Can This Be Tested/Reviewed?

Verify the email translations are updated

In order to test that the migration file properly works manual validation is required.

  1. Before pulling down these changes seed the database
  2. Pull down the changes and run yarn db:migration:run
  3. Verify that the database has the new fields and updated language for the accountRemoval field in the translations table

Verify the email looks correct

  1. Seed the database
  2. Create a public user with your email
  3. In the database update the last_login_at and password_updated_at to be way in the past
  4. Set the USER_DELETION_WARN_CRON_STRING value in the .env file to run soon (ideally the next few minutes)
  5. Set the USERS_DAYS_TILL_EXPIRY value in .env file to be a small number (e.g 1)
  6. Wait for the cron job to run and verify the received email looks correct

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@ludtkemorgan
ludtkemorgan force-pushed the 1017/warn-user-email branch from 8bea487 to c36d69f Compare June 15, 2026 15:18

@mcgarrye mcgarrye left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcgarrye mcgarrye added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jun 15, 2026
@ludtkemorgan
ludtkemorgan merged commit 19c1778 into main Jun 15, 2026
17 checks passed
@ludtkemorgan
ludtkemorgan deleted the 1017/warn-user-email branch June 15, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Should be applied when a PR has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants