Skip to content

fix: msq visible to draft check (#6530) - #1543

Merged
mcgarrye merged 1 commit into
mainfrom
fix/msq-visible-to-draft
Jul 22, 2026
Merged

fix: msq visible to draft check (#6530)#1543
mcgarrye merged 1 commit into
mainfrom
fix/msq-visible-to-draft

Conversation

@mcgarrye

Copy link
Copy Markdown
Collaborator

This PR addresses #(insert-number-here)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

A bug was found in Doorway where one could assign a visible MSQ to a draft listing and then change the status of the MSQ back to draft causing problems for the listing. A check has been added to prevent returning a visible MSQ to draft once it is associated with a listing.

Open question: do we want a better error message for this than the generic one on the FE?

How Can This Be Tested/Reviewed?

Run yarn setup --msqV2
Login to the partners site
Navigate to the Settings page
Create a Preference and Show to partners
Choose or create a draft listing and attach the visible MSQ
Return the the Settings page and attempt to return the MSQ to draft
Verify error occurs

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

* fix: msq visible to draft

* fix: update update tests

* fix: add better error messaging

* fix: adjust error catching
@mcgarrye
mcgarrye merged commit a762e84 into main Jul 22, 2026
17 of 18 checks passed
@mcgarrye
mcgarrye deleted the fix/msq-visible-to-draft branch July 22, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants