fix: msq visible to draft check (#6530) - #1543
Merged
Merged
Conversation
* fix: msq visible to draft * fix: update update tests * fix: add better error messaging * fix: adjust error catching
ludtkemorgan
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #(insert-number-here)
Description
A bug was found in Doorway where one could assign a visible MSQ to a draft listing and then change the status of the MSQ back to
draftcausing problems for the listing. A check has been added to prevent returning avisibleMSQ todraftonce it is associated with a listing.Open question: do we want a better error message for this than the generic one on the FE?
How Can This Be Tested/Reviewed?
Run
yarn setup --msqV2Login to the partners site
Navigate to the Settings page
Create a Preference and
Show to partnersChoose or create a draft listing and attach the visible MSQ
Return the the Settings page and attempt to return the MSQ to draft
Verify error occurs
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: