Repository navigation
Bump ws from 8.16.0 to 8.22.0 - #231
Merged
Merged
Conversation
Fixes GHSA-3h5v-q93c-6h6q, GHSA-58qx-3vcg-4xpx and GHSA-96hv-2xvq-fx4p. ws is a build-time dependency (laravel-mix > webpack-dev-server). Amp-Thread-ID: https://ampcode.com/threads/T-01a12fb4-ee3a-75ae-b35e-cec10b79e7e7 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #198. That PR only goes to 8.17.1, which fixes one of the three
wsadvisories.Closes #198.
Advisories fixed
<8.17.1<8.20.1<8.21.0wsis build-time only (laravel-mix→webpack-dev-server→ws,^8.13.0), so this doesn't affect anything shipped in the package. Only thewsentry inpackage-lock.jsonchanges.Verification
npm ci+mix --production(Node 20) builds successfully, andpublic/app.cssis byte-identical to the build frommaster's lockfile.npm audit:wsno longer reported.Why not
npm audit fixA plain
npm audit fixbreaks the build. It upgrades webpack to 5.111, which removedwebpack/lib/SizeFormatHelpers, a filelaravel-mix6 requires:The remaining advisories are in the
laravel-mixtoolchain and need a move to Vite to clear properly.Note
laravel-mixdoesn't currently run on Node 22+ (require is not defined in ES module scopefrom its bundledyargs). Use Node 20 to build assets. This is unrelated to this change;masterbehaves the same.