Repository navigation
Upgrade to Laravel 13 (v4.0.0) - #343
Merged
Merged
Conversation
- Require laravel/framework ^13.0, PHP ^8.3 and mettle/sendportal-core ^4.0 - Bump tinker to ^3.0, PHPUnit to ^12.5 and other dependencies to Laravel 13 compatible releases - Rename the VerifyCsrfToken middleware to PreventRequestForgery - Use Pdo\Mysql::ATTR_SSL_CA on PHP 8.5+ - Convert @test/@group doc-comment annotations to PHPUnit attributes - Test against PHP 8.3, 8.4 and 8.5 in CI Amp-Thread-ID: https://ampcode.com/threads/T-01a12ce4-5849-7298-9b52-0f19594ee434
The Env and Url setup steps check the local .env file and APP_URL, so the test only passed on machines with a configured .env (never in CI). Stub those two steps, and assert that the admin step is not completed instead of comparing its boolean `completed` flag to 5. Amp-Thread-ID: https://ampcode.com/threads/T-01a12ce4-5849-7298-9b52-0f19594ee434
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades the SendPortal application to Laravel 13 and sendportal-core 4.
Requires sendportal-core 4.0.0 (mettle/sendportal-core#226, released as
V4.0.0).Changes
laravel/framework^13.0, PHP^8.3,mettle/sendportal-core^4.0laravel/tinker^3.0,phpunit/phpunit^12.5, plus Laravel 13-compatible minimums for Horizon, UI, Livewire (still v3), Guzzle (still v7), Collision, Ignition, Faker and MockeryApp\Http\Middleware\VerifyCsrfTokentoPreventRequestForgery, matching Laravel 13's rename. Laravel 13's middleware also accepts same-origin requests viaSec-Fetch-Site.config/database.php: usePdo\Mysql::ATTR_SSL_CAon PHP 8.5+, wherePDO::MYSQL_ATTR_SSL_CAis deprecated (same as the Laravel 13 skeleton)@test/@groupannotations to PHPUnit attributes, migratephpunit.xml.dist, ignore.phpunit.cacheSetupTest::the_setup_command_should_stop_on_the_admin_step_if_there_are_not_users, which depended on the local.envandAPP_URLand had never passed in CI; it also compared a boolean to5Session and cache settings are set explicitly in the config files, so Laravel 13's new default prefixes don't apply.
Upgrade docs: mettle/sendportal-docs#28.