fix(drift): do not treat version-shaped refs as missing paths - #210
Open
dyk1454683243-sudo wants to merge 1 commit into
Open
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
Treat trailing numeric segments such as .0 or .11 as versions, not file extensions, so unrooted refs like release/2.1.0 are not MISSING_PATH. Fixes mex-memory#201 Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
dyk1454683243-sudo
marked this pull request as ready for review
September 19, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tighten the
isUnrootedReferenceextension guard so a trailing numeric-only segment is not treated as a file extension.release/2.1.0used to match/\.[A-Za-z0-9]+$/on.0, skip the prose/unrooted check, and reportMISSING_PATH. The guard now requires an alphabetic character in that suffix, so git-flow / pinned-runtime tokens (release/2.1.0,python/3.11,node/20.11) reach the existing first-segment check.Unskips
does not claim a version-shaped branch nameand adds a small regression thatdocs/foo.barstill stays a real path claim.The narrower
api/v1.2case (first segment exists on disk) is unchanged.Why
Fixes #201
mex checkwas flagging branch names and pinned runtimes as missing files whenever the last dotted segment was digits-only.Type of change
How to test
npx vitest run src/drift/__tests__/path-false-positives.test.tsdoes not claim a version-shaped branch namecase is active and green.npm run typecheckChecklist
npx vitest run src/drift— 12/12)npm run typecheck)npm test— not used as a gate here; this environment’s Node 22.14.0 SQLite is built without FTS5, which fails graph/wiki suites unrelated to this changeCode-graph changes
mainLanguageExtractororFrameworkResolverinterfacecore / discuss-firstissue is linked above