fix(drift): discover nested pyproject.toml and recursive package.json - #211
Open
dyk1454683243-sudo wants to merge 2 commits into
Open
dyk1454683243-sudo wants to merge 2 commits into
dyk1454683243-sudo wants to merge 2 commits into
Conversation
Share one bounded glob for package.json and pyproject.toml so a Python service in backend/ or a JS app in api/backend/ is read at the same depth. Keeps the entries-or-null contract and ignores generated trees. Fixes mex-memory#206 Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
A one-directory glob example used */ inside a block comment and terminated it. Rephrase so the file parses. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
loadAllDependenciesnow walkspackage.jsonandpyproject.tomlwith the same bounded recursive glob. Nested Python manifests (backend/pyproject.toml) and JS manifests more than one directory down (api/backend/package.json) are discovered;node_modulesand other generated trees stay ignored. Root-only behavior andparsePyprojectDependenciessemantics are unchanged. Theentries.length ? entries : nullcontract is preserved — widening discovery is what keeps a partial list from switching the checker on.Why
Fixes #206
A frontend
package.jsonat the repo root plus a Python service inbackend/produced falseDEPENDENCY_MISSINGfor FastAPI/Celery. The identicalpyproject.tomlat the root passed.*/package.jsonhad the same hole one level further down.Type of change
How to test
npx vitest run test/checkers.test.tsbackend/pyproject.toml(fastapi/celery) andapi/backend/package.jsonclaims pass, while undeclared packages still warnnpm run typecheckandnpm testChecklist
npm test)Code-graph changes
mainLanguageExtractororFrameworkResolverinterfacecore / discuss-firstissue is linked above