fix(drift): stop DEAD_COMMAND and INDEX_MISSING_ENTRY false positives - #212
Draft
dyk1454683243-sudo wants to merge 1 commit into
Draft
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
DEAD_COMMAND treated bare yarn/pnpm verbs such as install, add, dlx, and ci as missing package.json scripts. INDEX_MISSING_ENTRY ignored patterns/INDEX.md frontmatter edges that stale-pattern already treats as canonical navigation. Fixes mex-memory#203 Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small, independent drift-checker false positives from #203:
yarn/pnpmno longer look up builtins (install,add,dlx,ci, …) aspackage.jsonscripts.yarn run/pnpm runstill resolve the following token as a script, so a real missing script stays flagged.checkIndexSyncnow countspatterns/INDEX.mdfrontmatteredges[].targetas INDEX references, using the sameextractFrontmatter/edges[].targetshape asstale-pattern.ts. Sibling targets (syntax-extractor-review.md) andpatterns/*.mdtargets both count.Why
Fixes #203
mex checkreportedpnpm installas a missing script and reported a pattern reached only through an INDEX frontmatter edge as unreferenced. The sibling stale-pattern checker already treats those edges as canonical navigation.Type of change
How to test
npx vitest run test/checkers.test.tspnpm install/yarn addare notDEAD_COMMAND, andpnpm lint/yarn run missingstill are.INDEX_MISSING_ENTRY, and a file with no link or edge still is.npm run typecheckChecklist
npx vitest run test/checkers.test.ts— 111/111)npm run typecheck)npm test) — full suite hits this environment's Node SQLite-without-FTS5 limitation; failures are graph/wiki/hub, not these checkersCode-graph changes
mainLanguageExtractororFrameworkResolverinterfacecore / discuss-firstissue is linked above