fix(drift): treat qualified-name symbol notation as not a path - #220
Open
dyk1454683243-sudo wants to merge 1 commit into
Open
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
Drop tokens like `src/auth/login.validateToken` in isNotAPath when the final slash-segment is identifier.identifier and is not a known file extension. Real paths (`src/auth/login.ts`, `.mex/ROUTER.md`, `package.json`) stay claims. Addresses mex-memory#202 bullet 1 only. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Treat symbol / qualified-name notation such as
`src/auth/login.validateToken`as not a filesystem path, so it never becomes a path claim orMISSING_PATH.isNotAPathnow rejects values whose final slash-segment matchesidentifier.identifier(JS/TS method or property) and does not end in a known file extension. Real files stay claims:src/auth/login.ts,.mex/ROUTER.md,package.json. Extra dotted segments such asfoo.d.tsare left for #216.Why
Addresses #202 (bullet 1 only).
Do not treat this as
Fixes #202orCloses #202— that would auto-close the whole mega-issue.Remaining #202 bullets stay open:
.d.ts) — owned by fix(drift): treat compound extensions like .d.ts as not-paths #216./x,x.ts,x/index.ts)tests/grounding|traversal|…)@scope/pkg/package.jsonvs bare specifier) — owned by fix(drift): resolve scoped packages by bare specifier #217Type of change
How to test
npx vitest run src/drift`src/auth/login.validateToken`as aqualified_nameexample produces zero path claims and zeroMISSING_PATH.src/auth/login.tsis still reported asMISSING_PATH..mex/ROUTER.md/package.jsonstill extract as path claims.npm run typecheckChecklist
npx vitest run src/drift— 12 passed, 1 skipped#201version-shaped case left untouched)npx vitest run test/claims.test.ts— 30 passed, including the bullet-1 skip plus preserved real paths)npm run typecheck)npm test) — full suite is not the gate for thisisNotAPathfilterCode-graph changes
mainLanguageExtractororFrameworkResolverinterfacecore / discuss-firstissue is linked aboveThis is a drift claim-extraction filter only. It does not change graph identity, extractors, or the other #202 bullets. Issue #202 stays open.