Skip to content

fix: cache project tag lookups to avoid redundant XML parsing #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mfogliatto wants to merge 2 commits into from
Closed

fix: cache project tag lookups to avoid redundant XML parsing #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80d9430
fix: cache project tag lookups to avoid redundant XML parsing
mfogliatto May 25, 2026
74dbb45
fix: resolve C# 7.3 and StyleCop violations in ProjectTagProvider
mfogliatto May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions src/ReferenceCop/Providers/ProjectTagProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
namespace ReferenceCop
{
using System.Collections.Concurrent;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using System.Linq;
Expand All @@ -12,20 +13,25 @@ public class ProjectTagProvider : IProjectTagProvider
internal const string ProjectTagNode = "ProjectTag";
internal const string UnknownProjectTag = "Unknown";

private readonly ConcurrentDictionary<string, string> cache = new ConcurrentDictionary<string, string>();

public string GetProjectTag(string projectFilePath)
{
if (!File.Exists(projectFilePath))
return this.cache.GetOrAdd(projectFilePath, path =>
{
return UnknownProjectTag;
}
if (!File.Exists(path))
{
return UnknownProjectTag;
}

var projectFile = XDocument.Load(projectFilePath);
var projectTag = projectFile
.Descendants(PropertyGroupNode)
.Elements(ProjectTagNode)
.FirstOrDefault()?.Value;
var projectFile = XDocument.Load(path);
var projectTag = projectFile
.Descendants(PropertyGroupNode)
.Elements(ProjectTagNode)
.FirstOrDefault()?.Value;

return projectTag ?? UnknownProjectTag;
return projectTag ?? UnknownProjectTag;
});
}
}
}
Loading