Skip to content

[codex] Improve client mod coexistence safeguards#41

Merged
mfoltz merged 5 commits into
mainfrom
codex/eclipse-runtime-load-friendliness
May 17, 2026
Merged

[codex] Improve client mod coexistence safeguards#41
mfoltz merged 5 commits into
mainfrom
codex/eclipse-runtime-load-friendliness

Conversation

@mfoltz
Copy link
Copy Markdown
Owner

@mfoltz mfoltz commented May 17, 2026

Summary

This keeps Eclipse friendlier when another client UI mod or runtime loader is present without adopting any peer-mod behavior:

  • initialize config before Harmony patch discovery and add a runtime initialize receipt hook for partial/runtime-load paths
  • make unload/bootstrap teardown tolerate partially initialized routines and reset transient Core state
  • default the Bloodcraft attribute-buffer mutation behind UIOptions.AttributeBuffs=false
  • add defensive HUD/ability-slot null and duplicate-component guards during canvas bring-up
  • retry the Emberglass registration message after the client transport reports ready
  • add generic local mod-pair proof tooling so future compatibility checks can stage, collect, and restore without manually shuffling DLLs

Runtime Evidence

Local proof run eclipse-bloodcrafthub / combined-candidate / 20260517-111812 was marked pass-with-warning after a dedicated harness rerun.

Observed success markers:

  • Eclipse and BloodCraftHub loaded together without targeted CanvasService/DOTS/null-reference crash markers
  • Emberglass handshake completed
  • Eclipse observed Emberglass client ready
  • queued Eclipse registration sent after readiness
  • Eclipse received configs/progress afterward
  • server log showed Bloodcraft registered the Emberglass bridge and received Eclipse registration

The warning is intentionally not fixed here: Bloodcraft still logs an early startup-check warning and NullReferenceException before later initialization. That should be handled in a separate Bloodcraft follow-up.

Validation

  • dotnet build Eclipse.csproj --configuration Release --no-restore -p:DeployToClient=false
  • C:\Program Files\Git\bin\bash.exe .codex/scripts/version-metadata.sh
  • PowerShell parser check over .codex/scripts/*.ps1
  • git diff --check / git diff --cached --check

@mfoltz mfoltz marked this pull request as ready for review May 17, 2026 18:13
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ddb3fe4d7a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .codex/scripts/New-ModPairCompatibilityProof.ps1
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 572d8fccd9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .codex/scripts/New-ModPairCompatibilityProof.ps1 Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b66e074c59

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .codex/scripts/Use-ModPairClientProofProfile.ps1 Outdated
Comment thread .codex/scripts/Use-ModPairClientProofProfile.ps1
@mfoltz mfoltz merged commit 2074fb1 into main May 17, 2026
6 checks passed
@mfoltz mfoltz deleted the codex/eclipse-runtime-load-friendliness branch May 17, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant