Repository navigation
feat(app): the custom title bar draws the window's title, "TaskSmack (Administrator)" in an Administrator session (#2728) - #2949
Merged
Conversation
…(Administrator)" in an Administrator session (#2728) #2934 set the OS window title, which the taskbar and window switcher show, but TaskSmack's own borderless title bar drew a literal "TaskSmack". Core::Window now keeps the title it set (title()), TitleBarLayer hands it to TitleBarView::Input::title, and the view draws that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mgradwohl
added
enhancement
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
github-actions
Bot
added
the
documentation
mgradwohl
enabled auto-merge (squash)
October 25, 2026 23:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #2728 ("Window title: 'TaskSmack (Administrator)' when elevated"). #2934 set the OS window title, which shows in the taskbar, the window switcher and native title bars. But TaskSmack's own borderless title bar, the one usually on screen, drew a hardcoded
"TaskSmack", so in an Administrator session it still said just "TaskSmack".Core::Window:setTitle()now keeps the title in the window spec, andtitle()returns it.TitleBarView::Input: newtitlefield (default"TaskSmack"), drawn in place of the literal.TitleBarLayerpasseswindow.title().This applies on every platform: the custom bar now always matches the OS title.
PR Size
✅ Small (~60 lines, 7 files).
Type of Change
Checklist
clang-tidyand addressed any warningsclang-formaton my changespre-commit run --all-filesor installed pre-commit hooksTesting
TASKSMACK_REQUIRE_DISPLAY=1 TASKSMACK_REQUIRE_SDBUS=1 xvfb-run -a env -u WAYLAND_DISPLAY ctest --preset debug -j 4 # 682/682New test:
TitleBarViewRenderTest.TheBarDrawsTheWindowsTitle. It captures the bar's drawn text and checks that "TaskSmack (Administrator)" appears only when that's the title.Additional Notes
v0.10.0, no backport.
🤖 Generated with Claude Code