Repository navigation
fix(app): a synthetic run on Linux is never an Administrator session in the window title or the access chip (#3004) - #3005
Merged
Conversation
…in the window title or the access chip (#3004) Both asked whether nothing was limited (hasReducedPrivileges), which the synthetic probe always says, since its stand-in machine shows everything; the docs' screenshots come from synthetic runs. One decision for both now, ShellLayer::isAdministratorSession(): held for the session, or nothing limited on a real machine. UiScenarioTest, which drives the whole shell on a synthetic machine, checks the title reads plain "TaskSmack". Fixes #3004 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
mgradwohl
enabled auto-merge (squash)
October 26, 2026 03:28
7 tasks done
…ccess title (#3004) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mgradwohl
disabled auto-merge
October 26, 2026 03:43
mgradwohl
enabled auto-merge (squash)
October 26, 2026 03:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3004
On Linux, a synthetic run (
TASKSMACK_SYNTHETIC) called itself an Administrator session: the window title read "TaskSmack (Administrator)" (#2934), and the access chip showed Administrator (#2913). Both asked "is nothing limited?" (hasReducedPrivileges), and the synthetic probe always says yes, because its stand-in machine shows everything. A synthetic machine's process actions are all refused, and the docs' screenshots are captured from synthetic runs (#2827).There's now one decision for both,
ShellLayer::isAdministratorSession(): the helper is held for the session, or nothing is limited on a real machine.PR Size
✅ Small (~25 lines, 3 files).
Type of Change
Checklist
clang-tidyand addressed any warningsclang-formaton my changespre-commit run --all-filesor installed pre-commit hooksTesting
UiScenarioTest.TheSignOffStepsRunThroughTheWholeShelldrives the whole shell on a synthetic machine. It now checks the window title reads plain "TaskSmack"; before the fix it read "TaskSmack (Administrator)". The full suite passes, 683/683.Additional Notes
Found while running TaskSmack under headless sway for #2724. v0.10.0, no backport: #2913 and #2934 aren't on
release/0.9.🤖 Generated with Claude Code