fix: implement proper structural serialization for Julia executable folds#16
Open
Parth-Garg2629 wants to merge 1 commit intomgubi:mainfrom
Open
fix: implement proper structural serialization for Julia executable folds#16Parth-Garg2629 wants to merge 1 commit intomgubi:mainfrom
Parth-Garg2629 wants to merge 1 commit intomgubi:mainfrom
Conversation
Author
|
@hammerfunctor could u please check if this meets the requierments you told about earlier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the issue where multiline Julia code in executable folds was being concatenated into a single line, leading to
ParseErrorin the Julia kernel (Issue #14 ).Following the maintainer's feedback, instead of disabling input converters, we have implemented a dedicated recursive serializer that respects the TeXmacs document structure while preserving formatting capabilities.
Technical Details
The fix is implemented in progs/init-julia.scm through the following changes:
julia-serialize-sub: A new recursive function that traverses the TeXmacs tree to handle different node types appropriately.documentnodes and joins their children (lines) with\ncharacters. This ensures that multiline code blocks are sent to Julia with their structural integrity intact.plugin-math-inputby calling it specifically formathtags. This ensures that mathematical symbols (e.g.,<math|\alpha>) are still correctly translated for the Julia kernel (e.g., toalpha).plugin-configureblock as the primary method for code output.This approach ensures that the Julia kernel receives well-formatted, multiline code while maintaining all the benefits of TeXmacs' structured document system.
Verification
ParseError.