fix: correct MIME types for SVG and JPEG inline display#20
Open
PranavGadge01 wants to merge 2 commits intomgubi:mainfrom
Open
fix: correct MIME types for SVG and JPEG inline display#20PranavGadge01 wants to merge 2 commits intomgubi:mainfrom
PranavGadge01 wants to merge 2 commits intomgubi:mainfrom
Conversation
Author
|
@hammerfunctor could u please check... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
tm_mimetypespriority list inTeXmacsJulia.jlcontainedtwo incorrect MIME type strings:
"image/svg"— not a valid MIME type, should be"image/svg+xml""image/jpg"— not a valid MIME type, should be"image/jpeg"Because
showable(MIME("image/svg"), x)andshowable(MIME("image/jpg"), x)never match any object, SVG and JPEG outputs silently fell through to
text/plain, rendering as raw object descriptions instead of images.Additionally, no display handler existed for SVG at all.
This can be verified in a plain Julia REPL:
Fix
"image/svg"→"image/svg+xml"intm_mimetypes"image/jpg"→"image/jpeg"intm_mimetypesdisplayhandler forMIME"image/svg+xml"