Add vector list datatype & add configurable SPACE_DIRECTIONS_TYPE option - #157
Merged
Conversation
Utilize np.asarray in relative formatters to ensure array is a numpy array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
int vector listanddouble vector listdatatypes that are lists of Numpy arrays orNone.int matrixanddouble matrixcounterparts except they are not 2D Numpy matrices.nrrd.SPACE_DIRECTIONS_TYPEto enable switching the datatype for thespace directionsfield.double matrixordouble vector list. The current default isdouble matrixfor backwards compatibility but will be switched todouble vector listin the next major release.double vector listis superior overdouble matrixbecause it doesn't have the confusing row-of-NaN's representation and it doesn't imply an affine transform by being a matrix.parse_optional_matrix&format_optional_matrixin addition to new vector list parsing/formatting functionsFixes #148
Revises #149