fix: add refType parameter to configuration_get tool so version tags resolve correctly - #97
Merged
Merged
Conversation
…resolve correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR is for?
The
configuration_gettool always queried the Console backend's configuration endpoint using therevisionspath segment, regardless of whether the caller'srefIdwas actually a revision name or a version tag. Since the backend route is generic (GET /projects/:projectId/:refType/:refName/configuration, supporting bothrevisionsandversions), a version tag looked up underrevisionsfailed to resolve and fell back to a mostly-empty configuration document (onlycmsSettings/fastDataConfigremained populated).This PR adds an explicit
refType: 'revision' | 'version'parameter toconfiguration_get(defaulting to'revision'to preserve existing behavior), and threads it throughIAPIClient.getConfigurationandBackendClientso the correct path segment (revisions/versions) is used when querying the backend.Tests were added first to reproduce the bug (asserting the request path used
revisionseven for a version ref), then the fix was implemented to make them pass, alongside new coverage for theversionref type.