Conversation
|
Is it backwards compatible? I have this on my list for a moment, but no time until know, therefore it would be a nice addition. |
miaucl
changed the title
I'm not sure what you mean by that. I forked the master and added the code in a branch based on the latest master. |
|
Sorry, without testing on my side I just wanted to make sure leaving out all tls configs, it still works. As I do not have a setup with TLS ready for now, I cannot really test your PR but only ensure that the existing functionality is not broken. I will trust your change that it works with TLS and come back to you, when there is an Issue regarding it ;) |
miaucl
left a comment
miaucl
left a comment
There was a problem hiding this comment.
But, as you might see, there are 2 checks failing, which means you did not run the linter and formatter. Please have a look at the Readme.md, how to do that.
Okay, fair enough. For me it works since I'm currently migrating all my MQTT communication to TLS with no exceptions. I will have a look at the linter and formatter stuff. |
|
Also, there is already another PR for this, might be worth to have a look at it |
The other code looks better than mine. As I told you I was using AI to help me add this feature since I did't see the other PR. Just wanted to contribute back. The other implementation also has documentation and looks more comprehensive in terms of setting default values. I have fixed the linter stuff and the trailing whitespaces but you should give the other PR a go. I would happily switch to the implementation by sholdee then. |
|
Okay, the other code doesn't work on my machine when I build the container. The error is caused by an incompatibility issue between linux2mqtt and the installed version of psutil. I would need to have a much more details look at the code to fix this. If sholdee is not responding I could have a look afte rthe Easter break. |
|
No hurry from my side, take your time. It is also what I tought, it would be better to build on his PR with already some things in place. |
|
duplicate #72 |
2 participants
Hi there,
I have added TLS support for your project. I'm not a developer but I took aid in using perplexity. It works fine with docker on my 2nd Raspberry Pi to transfer telemetric data to my Home Assistant setup. Even mTLS works fine.
I have not updated the documentation yet. I would do that if this is merged.
Hope that helps.
Best regards
Carsten