DeltaP thresholds for weak walls and fans, and more#238
Draft
BobSempleD wants to merge 2 commits intomichaelchessall:masterfrom
Draft
DeltaP thresholds for weak walls and fans, and more#238BobSempleD wants to merge 2 commits intomichaelchessall:masterfrom
BobSempleD wants to merge 2 commits intomichaelchessall:masterfrom
Conversation
Fixed deltaP threshold names for bananium, gold, and cult walls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET; NEEDS TESTING & FIXES
About the PR
Basic walls & fans are no longer immune to high pressure; certain walls are now more(gold, plasma, and uranium walls) or less(plastic, wood, titanium, and web walls) effective in blocking radiation. Fans have a chance to revert to their flatpack when broken.
Solid walls have the same deltaP threshold as reinforced plasma windows, so they are still able to withstand typical pressure-regulated burn chamber pressures. Any walls with structuralMetallicStrong are still completely immune to pressure.
I also made titanium walls lighter because why not.
Why / Balance
Fans that you can walk through being able to withstand unlimited pressure when reinforced windows can't is silly.
It doesn't make sense for plastic & wood walls to provide the same radiation protection as steel. I have never seen plasma or uranium walls used, so I slightly improved their radiation resistances (plasma from 5->6 and uranium from 6->7).
Technical details
Media
Requirements
Breaking changes
Pressure chambers using any of the following for containment should have their pressure regulators updated with the following thresholds:
Tiny fans, plastic walls, and web walls: 750 kPa
Directional fans: 2.5 MPa
Wood, meat, and cobblestone brick walls: 10 MPa
Solid(basic steel walls), brick, bronze, clockwork, ice, silver, plasma(wall), uranium(wall), and chitin: 150 MPa
Gold and cult walls: 300 MPa
Changelog