Populate kind in california-housing pusher config - #16
Merged
Conversation
sallycr
changed the title
sallycr
force-pushed
the
add-pusher-kind-model-family
branch
5 times, most recently
from
August 5, 2026 19:17
5fb5c64 to
e4f6457
Compare
Companion change to michelangelo-ai/michelangelo's "Add kind to ModelPusherPlugin" (adds this field to ModelPusherPlugin/ModelPluginConfig). Without setting it, the registry UI's Type column renders blank for models produced by these example pipelines (the gap identified in michelangelo PR #1673). - Set kind=ModelKind.REGRESSION on both the pytorch_train and xgb_train pipelines' ModelPluginConfig, so registered models exercise the new registry field end-to-end. Depends on the companion michelangelo repo PR (adds ModelKind) landing first, or being available as a compatible dependency version.
pyproject.toml's floor was bumped to 0.8.0 (#26), but uv.lock still pinned 0.4.0rc2 -- predating both the ModelKind class this PR imports and the model-name format fix in michelangelo#1633. Regenerating the lock is required for this PR to actually build/import.
sallycr
force-pushed
the
add-pusher-kind-model-family
branch
from
August 11, 2026 00:32
e4f6457 to
c699784
Compare
kenns29
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR to michelangelo-ai/michelangelo's "Add kind to ModelPusherPlugin" (adds this field to
ModelPusherPlugin/ModelPluginConfig). Without setting it, the registry UI's Type column renders blank for models produced by this example pipeline — the gap identified in michelangelo's #1673.kind=ModelKind.REGRESSIONon thepytorch_lightning_trainpipeline'sModelPluginConfig, so the registered model exercises the new registry field end-to-end.model_familyis not set here — it was deferred from the companionmichelangeloPR pending further design review. MLflow, Vertex AI, and BentoML have no native "family" grouping concept above a registered model, so a dedicated kwarg wouldn't buy the same cross-registry interoperability benefit thatkindgets from its typed enum.Depends on the companion
michelangelorepo PR (addsModelKind) landing first, or being available as a compatible dependency version.Test plan
python -m py_compileon the updatedpush.py— no syntax errors