Make Slf4jThreadLocalAccessor loadable by ServiceLoader#554
Open
jonatan-ivanov wants to merge 1 commit into
Open
Make Slf4jThreadLocalAccessor loadable by ServiceLoader#554jonatan-ivanov wants to merge 1 commit into
jonatan-ivanov wants to merge 1 commit into
Conversation
Slf4jThreadLocalAccessor were not loaded by ServiceLoader because it does not have a public, no-arg constructor, producing the following exception: java.util.ServiceConfigurationError: io.micrometer.context.ThreadLocalAccessor: io.micrometer.context.integration.Slf4jThreadLocalAccessor Unable to get public no-arg constructor Closes gh-540
chemicL
requested changes
May 29, 2026
Comment on lines
+47
to
+48
| * Create an instance of {@link Slf4jThreadLocalAccessor}. If used directly or through | ||
| * the {@code ServiceLoader}, the entire contents of the {@link MDC} are propagated. |
Contributor
There was a problem hiding this comment.
I'd stick a warning here that using this as a service causes the global variant to be used that catches the entire map backing SLF4J's context. If any other library (e.g. Micrometer itself) stores anything in the context (trace identifiers) this service together with Micrometer would step on each others' toes. I believe this begs for a huge warning.
Member
Author
There was a problem hiding this comment.
This is why I now think maybe we should keep this as-as and document that this needs to be explicitly registered manually (maybe also giving them a workaround: extending the class and defining a default ctor in the child).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slf4jThreadLocalAccessor were not loaded by ServiceLoader because it does not have a public, no-arg constructor, producing the following exception:
Closes gh-540